Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export types for block-dynamic-connection #1948

Merged

Conversation

eldu
Copy link
Contributor

@eldu eldu commented Sep 22, 2023

The basics

The details

Resolves

Fixes #1896

Proposed Changes

Export types for block-dynamic-connection

Reason for Changes

The types were previously not exported

Test Coverage

None?

Documentation

Additional Information

@eldu eldu requested a review from a team as a code owner September 22, 2023 17:32
@eldu eldu requested review from maribethb and removed request for a team September 22, 2023 17:32
@google-cla
Copy link

google-cla bot commented Sep 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for your contribution, @eldu!

@maribethb maribethb merged commit ffa3797 into google:osd Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish types for block-dynamic-connection plugin
2 participants