Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add textures for the pixel shaders #268

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Add textures for the pixel shaders #268

merged 1 commit into from
Aug 18, 2023

Conversation

elviscapiaq
Copy link
Collaborator

  • It was added the textures for Albedo, NormalMap and metalness-roughness.

@elviscapiaq elviscapiaq requested a review from apazylbe August 16, 2023 15:49
apazylbe
apazylbe reviewed Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@apazylbe apazylbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise lgtm

Keenuts
Keenuts approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@Keenuts Keenuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the file copy we could avoid.
I'll merge once the conflict is resolved.

@elviscapiaq
Copy link
Collaborator Author

I avoided copying files for textures and also rebased the PR.

@elviscapiaq
Add textures for the pixel shaders
4b5cadb 
- It was added the textures for Albedo, NormalMap and metalness-roughness.
@elviscapiaq elviscapiaq requested a review from Keenuts August 18, 2023 17:52
@apazylbe apazylbe merged commit e34b91e into google:main Aug 18, 2023
@elviscapiaq elviscapiaq deleted the textures_ps branch August 22, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apazylbe apazylbe apazylbe left review comments

@wangra-google wangra-google wangra-google approved these changes

@Keenuts Keenuts Awaiting requested review from Keenuts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elviscapiaq @Keenuts @apazylbe @wangra-google