Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppCheckCore] Skip local cache when making network requests #78

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Oct 17, 2024

All of the URL sessions within used App Check are ephemeral. While they don't write a cache to disk, they do persist one to RAM. Cache policy can be controlled at the NSURLRequest level, and by default, the cache may be read from in some scenarios.

The SDK is intentional about making requests and hitting the cache may cause successive requests to send outdated artifacts. Therefore, we should try setting the cache policy to skip the local cache.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment.

@ncooke3
Copy link
Member Author

ncooke3 commented Oct 17, 2024

Will do, @paulb777. Will also send a changelog entry update. Does v11.2.0 sound good to you?

@ncooke3 ncooke3 merged commit 4b265b9 into main Oct 17, 2024
2 checks passed
@ncooke3 ncooke3 deleted the nc/skip-cache branch October 17, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants