-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keyboard hiding bug #2652
Fix keyboard hiding bug #2652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @FikriMilano!
I have one concern with regards to your video - it seems to me with this option the screen is no longer adjusted to make room for the soft keyboard. And in your video you're only able to input text because the screen is just big enough so that the soft keyboard is not covering the text input right? If the screen was a little shorter the keyboard would actually cover the text input.
So, is there something we need to do in terms of the layout to make sure that doesn't happen?
...apture/src/main/java/com/google/android/fhir/datacapture/views/OptionSelectDialogFragment.kt
Show resolved
Hide resolved
- With unmerged PR #9 - WUP PR google#2178 - WUP google#2652 - WUP google#2521 - WUP google#2645 - WUP google#2648 - WUP google#2650
…id-fhir into 2651-keyboard-hides-itself
@jingtang10 Hard to say, I don't have a good idea at the moment. But, I found this article that might be able to truly fix this issue by adding windowIsFloating tag. I'm not sure of it's downsides though. I'm going to try it and ask my QA to test it (I couldn't replicate the issue).
|
The solution by adding ScreenCapture_20240805_125237_163.mp4 |
What's the latest on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this seems not a perfect solution (not sure if one exists) it does solve the intial problem and we're moving from a deprecated constant to one that's not deprecated. So happy to approve this.
Thanks @FikriMilano for fixing this!
* Fix keyboard hiding bug * Update comment
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2651
Description
Change ADJUST_RESIZE to ADJUST_PAN
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Bug fix
Video
Blu G60 Android 9
326351102-a955eb10-7d2e-486c-b941-e106634a392a.mp4
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.