Hide the Next button if it is disabled #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added 2 commits
January 11, 2024 17:21
jingtang10
approved these changes
Jan 15, 2024
sharon2719
pushed a commit
to opensrp/android-fhir
that referenced
this pull request
Feb 6, 2024
* add horizontalscrollview to bottom navigation * Revert horizontal scrollview. * Make Next button hidden if disabled. * spotless apply. * Add android tests. * Removed dead code. * Add missing file. --------- Co-authored-by: Santosh Pingle <spingle@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2404
Description
One approach is to add a HorizontalScrollView, allowing users to scroll and view partially hidden buttons. In this case, disabled buttons can also be shown.
Alternative(s) considered
Alternatively, you can choose to hide the disabled buttons, ensuring enough space for other buttons to be rendered on the screen.
#2397 fix the issue indirectly
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.