-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the catalog app, load the questionnaire JSON file from the local storage of the phone. #2088
Conversation
Screen.Recording.2023-07-21.at.3.57.24.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@santosh-pingle thanks for the quick work!
catalog/src/main/java/com/google/android/fhir/catalog/ComponentListFragment.kt
Outdated
Show resolved
Hide resolved
catalog/src/main/java/com/google/android/fhir/catalog/ComponentListFragment.kt
Outdated
Show resolved
Hide resolved
catalog/src/main/java/com/google/android/fhir/catalog/ComponentListFragment.kt
Outdated
Show resolved
Hide resolved
catalog/src/main/java/com/google/android/fhir/catalog/ComponentListFragment.kt
Outdated
Show resolved
Hide resolved
Screen.Recording.2023-07-24.at.8.45.37.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try to avoid code duplication in the three different fragments?
catalog/src/main/java/com/google/android/fhir/catalog/MainView.kt
Outdated
Show resolved
Hide resolved
catalog/src/main/java/com/google/android/fhir/catalog/BehaviorListFragment.kt
Show resolved
Hide resolved
catalog/src/main/java/com/google/android/fhir/catalog/DemoQuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
catalog/src/main/java/com/google/android/fhir/catalog/BehaviorListFragment.kt
Show resolved
Hide resolved
catalog/src/main/java/com/google/android/fhir/catalog/DemoQuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
catalog/src/main/java/com/google/android/fhir/catalog/MainActivity.kt
Outdated
Show resolved
Hide resolved
catalog/src/main/java/com/google/android/fhir/catalog/MainActivity.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Santosh!
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2081
Description
Use storage access framework to load/open the questionnaire json file from local storage of the phone.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.