Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the catalog app, load the questionnaire JSON file from the local storage of the phone. #2088

Merged
merged 23 commits into from
Aug 22, 2023

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2081

Description
Use storage access framework to load/open the questionnaire json file from local storage of the phone.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle santosh-pingle marked this pull request as ready for review July 21, 2023 11:12
@santosh-pingle santosh-pingle requested a review from a team as a code owner July 21, 2023 11:12
@santosh-pingle santosh-pingle requested a review from aditya-07 July 21, 2023 11:12
@santosh-pingle
Copy link
Collaborator Author

Screen.Recording.2023-07-21.at.3.57.24.PM.mov

@santosh-pingle santosh-pingle changed the title In the catalog app, load the questionnaire JSON file from the local device storage of the phone. In the catalog app, load the questionnaire JSON file from the local storage of the phone. Jul 21, 2023
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santosh-pingle thanks for the quick work!

@santosh-pingle
Copy link
Collaborator Author

Screen.Recording.2023-07-24.at.8.45.37.PM.mov

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to avoid code duplication in the three different fragments?

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Santosh!

@santosh-pingle santosh-pingle merged commit 4c2da74 into google:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Load custom questionnaires in the catalog app
4 participants