Timestamp init wait occurs after dataSource.open() #9777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opening the `DataSource` is one of the longer operations in the `Loader` sequence, as it requires a round trip to the origin server. This change allows all the potential `Loader` threads to perform this operation before one of them is forced to wait on shared TimestampAdjuster initialization. Also, the initialization segment load will never produce media samples, so there is no need for it to wait for `TimestampAdjuster` initialization.
|
Sorry this took a while @ojw28 This is what we talked about in issue #8952 Great idea to add the boolean, this way any init data can load in parallel with the other loader threads as it will of course never produce samples. Here's the before sequence diagram And after sequence diagram |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening the
DataSourceis one of the longer operations in theLoadersequence, as it requires a round trip to the origin server. This change allows all the potentialLoaderthreads to perform this operation before one of them is forced to wait on shared TimestampAdjuster initialization.Also, the initialization segment load will never produce media samples, so there is no need for it to wait for
TimestampAdjusterinitialization.