Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DTS:X Audio Mime Type #9162

Closed
wants to merge 1 commit into from
Closed

Added DTS:X Audio Mime Type #9162

wants to merge 1 commit into from

Conversation

ProtoScott
Copy link
Contributor

For dtsx mimetype to be IANA compliant using vnd.dts.uhd instead of vnd.dts.x

@ProtoScott
Added DTS_X Audio Type
de53b60 
For dtsx mimetype to be IANA compliant using vnd.dts.uhd instead of vnd.dts.x
@google-cla google-cla bot added the cla: yes label Jul 8, 2021
@ProtoScott ProtoScott changed the base branch from release-v2 to dev-v2 July 8, 2021 09:04
@krocard
Copy link
Contributor

krocard commented Jul 8, 2021 •
edited
Loading

Thanks for the pull request. Nevertheless we don't usually list formats that are not handled by ExoPlayer.
Why do you need this value if ExoPlayer doesn't support it?

@krocard krocard self-requested a review July 8, 2021 09:53
@krocard krocard self-assigned this Jul 8, 2021
@krocard
Copy link
Contributor

krocard commented Jul 8, 2021 •
edited
Loading

Additionally vnd.dts.uhd has a required parameter profile. I believe only profile=p2 corresponds to dtsx so I don't think the pull request is correct.
Source: https://www.iana.org/assignments/media-types/audio/vnd.dts.uhd

@ProtoScott
Copy link
Contributor Author

Hi @krocard
We have written an extension library to support dtsx and are looking to use the MimeType class from the exoplayer core library.
The specific MimeType in the PR was specified by the Xperi (DTS:X) team

@ProtoScott
Copy link
Contributor Author

Closing for alternative PR: #9163

@ProtoScott ProtoScott closed this Jul 8, 2021
@google google locked and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krocard krocard Awaiting requested review from krocard

Assignees

@krocard krocard

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ProtoScott @krocard