feat(MediaSource): client code can get the tag of a MediaSource

[BrainCrumbz]

Closes #5177

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

[GiuseppePiscopo]

I'm ok with my commits being contributed to this project.

[BrainCrumbz]

For completeness: when running tests (on a Windows dev machine) we experienced 28 failed tests both before and after the change.

[tonihei]

For completeness: when running tests (on a Windows dev machine) we experienced 28 failed tests both before and after the change.

That's interesting :) Would you mind giving us a list? No one in our team is using Windows, so probably difficult to fix, but still seems worth knowing why they fail.

[tonihei]

Thanks, looks good in general.

[tonihei]

on the media source

[tonihei]

Can you move the method somewhere else to keep the release methods bundled together? For example, above addEventListener or below removeEventListener.

[tonihei]

Also, can you make this a default method which returns null for now? That prevents breaking other existing implementations.

[tonihei]

@nullable is missing here too.

[BrainCrumbz]

Re. test failing on Windows 10: on branch dev-v2, commit

ffbb0da Prevent Cea608Decoder from generating Subtitles with null Cues list.

here are attached the test results (exported as zipped HTML):

Test Results - exoplayer2_in_library-core - ffbb0da.zip

[BrainCrumbz]

Requested changes have been added. Not sure whether those return null should stay in ConcatenatingMediaSource.java. After all, they could be totally replaced by default implementation.

[tonihei]

Requested changes have been added.

Thanks! Looks good on a code level. I'd also keep the return null where it is because it's intentional (compared to just not implemented yet).
Let's use the issue to clarify the need to do this.

attached the test results

That's good to see. I suspect they all fail because of some line separator or encoding difference.

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

[BrainCrumbz]

I'd also keep the return null where it is because it's intentional (compared to just not implemented yet).

True, totally agreeing on making it explicit.

Let's use the issue to clarify the need to do this.

Not sure what you mean. If there's some action we should do on this side, just tell us please

[tonihei]

Not sure what you mean.

Never mind, I was referring to the ongoing discussion in #5177.