keep hls chunk source from getting redundant playlists #5058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
when playing live hls stream, ExoPlayer periodically getting all playlists which has been loaded at least once. Because of this, ExoPlayer keeps sending network requests more than necessary.
Environment
since version 2.9.0
This is the url that I tested, and it is reproducible on ExoPlayer demo.
You will see ExoPlayer keeps fetching all variants of mediaPlaylist which ExoPlayer has loaded during the playback.
Cause
Inside the HlsChunkSource, HlsChunkSource#createMediaChunkIterators() provides MediaChunkIterator[] that contains information for upcoming media chunks. However, in
createMediaChunkIterators()
, playlistTracker.getPlaylistSnapshot(variantUrl) is called and it sends an network request to fetch an MediaPlaylist. It's called for every variant that hasplaylistSnapshot
.I think unselected playlists should no be loaded through network calls from the viewpoint of reducing network requests.