r2.8.3 #4556
Merged
r2.8.3 #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows DrmInitData to carry a license server URL when the media declares one. Issue:#3393 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=199643743
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=201678261
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=201678686
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=201679215
Issue:#3393 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=201694813
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=201695876
…sible to skip entire ad groups but not individual ads within a given ad group.
Issue: #3879 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=202100576
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=202103550
Issue: #4413 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=202277924
Currently we immediately stop searching after we found one video and one audio track. This change adds some leeway to detect additional tracks. Issue:#4406 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=202455491
It's quite hard to find the defaults currently. Placing them on each variable makes them easier to find. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=202495929
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=202623116
Issue: #4321 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=202660712
Issue: #4029 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=202912333
Both boxes should contain the same list of track indices. However, if only one track index in each list does not match, we can just assume that these belong together. Issue:#4477 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=203481258
MediaDrm.provideXResponse methods only accept the response corresponding to the most recent MediaDrm.getXRequest call. Previously, our code allowed the following incorrect call sequence: a = getKeyRequest b = getKeyRequest provideKeyResponse(responseFor(a)); This would occur in the edge case of a second key request being triggered whilst the first was still in flight. The provideKeyResponse call would then fail. This change fixes the problem by treating responseFor(a) as stale. Note that a slightly better fix would be to defer calling getKeyRequest the second time until after processing the response corresponding to the first one, however this is significantly harder to implement, and is probably not worth it for what should be an edge case. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=203481685
If there is only one track, we can assume that both boxes refer to the same track even if the track indices don't match. Issue:#4083 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=203485872
Viewport constraints apply to adaptive content even if the actual playback isn't adaptive (i.e. because the selector ends up making a fixed track selection). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=203726831
Until now, the streams were released and re-enabled for each type of stream (primary, event, embedded) in that order. That leads to problems when replacing streams from one type to another (for example embedded to primary). This change restructures the track selection to: 1. Release and reset all streams that need to be released or replaced. 1(a). Including embedded orphan streams. 2. Select new streams. Issue:#4477 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=203751233
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=203766579
It's no longer text specific (it's used for metadata as well, and in theory could apply to any stream in which samples contain multiple sub-samples) ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=203767825
Also fixed showing "remove notification" when download is completed. Issue:#4469 Issue:#4488 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=203927268
Issue: #4348 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=204261718
After [] we support default font size for TTML, relative to the cellResolution of the document. However, this introduced a bug that makes TTML font-size in such case always follow the cellResolution font size, even when SubtitleView.setApplyEmbeddedStyles(false) and SubtitleView.setApplyEmbeddedFontSizes(false) were used. This CL updates the fix so that the default font-size using cellResolution works in the same way as other embedded styles, and can be turned off using setters from SubtitleView. GitHub: #4491 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=204467033
The sample queues haven't been created when the first init call occurs. In this case we need to set sourceId when we subsequently create the queues. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=204467538
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=205373398
The number is shelved in calls to queue.clear() to keep it for the next media period. However, the queue may also become empty by repeated calls to advancePlayingPeriod which may happen when seeking to an unprepared period. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=205376036
Amazon like to use Device.MODEL, so key on that instead for these workarounds. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=206917935
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=205988261
Inner classes generally has generic names and they make sense when they are considered with the top level class they appear in. When this setting is disabled, Android Studio inserts import for the top level class and append the top level class's name before the reference to the inner class name. NO_SQ ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=206127763
Issue:#4573 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=206737252
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
For now, just allow any prefix (and don't check the namespace). Checking the namespace requires turning on the XmlPullParser namespace awareness feature, but this can only be done before parsing, and I think requires us to specify the namespace when querying other attributes. This would also risk breaking services who currently don't set namespaces correctly. It's possible we'll run into similar issues with the few other tags (e.g. mspr:pro). We should revisit enabling namespace awareness if/when we see this. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207526883
EventSampleStream.readData required eventStreamUpdatable to be false for END_OF_STREAM to be returned, but it was only being set to false when the manifest became static. This change also sets it to false if the period is not the last one in a dynamic manifest. It also renames it the parameter to appendable, since that's what it really represents. Events may still be removed from the start of the EventStream as the period starts moving out of the live window. Issue: #4492 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207517265
See https://support.google.com/accessibility/android/answer/7661305. Also fix/suppress nullability warnings. Issue: #4611 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=207245115
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.