Include Pixel Aspect Ratio in DebugTextViewHelper #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't useful information for the many apps that will only ever be playing content with par=1. Can we show it only if it's not equal to 1 or Format.NO_VALUE (both of which are the boring case)? |
|
Yea, that makes total sense. I'll update the PR to conditionally include this only when it's relevant. |
|
Are you planning to update this? Else we will close it. Thanks. |
|
Apologies, I am, I'm travelling for work the last few weeks, so haven't had a chance just yet. I'll be back to the office Monday! |
Add the video Pixel Aspect Ratio to the DebugTextViewHelper in order to help debug issues related to PAR changes etc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the video Pixel Aspect Ratio to the DebugTextViewHelper in order to help debug issues related to PAR changes mid-stream.
This info is useful to know and have available, so that my apps users (when they have debugging enabled) can see both the resolution and stretch applied.