-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SmoothStreaming TTML fMP4 crashes player #5378
Comments
This is related to confusion around how subtitles are handled in DRM protected SmoothStreaming. An attempt was made to assume they're always unprotected in #4838 (which is the case in the sample provided). But it looks like the solution for doing so wasn't quite complete. It's easy to fix; we'll use this issue for tracking. |
Issue: #5378 PiperOrigin-RevId: 229261658
Fixed in |
Thanks a lot for the quick action, @ojw28! I'll try to verify it this week and get back to you. Can you please forecast which version could incorporate this fix? |
It'll be in 2.9.4. |
Issue: #5378 PiperOrigin-RevId: 229261658
Hi @ojw28, just came back to let you know that your fix is working marvelously. Many thanks for the prompt action! |
Glad to hear it; thanks for confirming! |
Issue description
After enabling the subtitle track during encrypted playback, the player crashes.
Setup: SmoothStreaming with PlayReady DRM, TTML in fMP4 (not encrypted)
Comparison: DRM-free SmoothStr with same subtitle setup plays flawlessly.
Link to test content
Manifest URL sent via email.
Might not be possible to play as the DRM license request requires a special header which includes an OAuth token that expires after a time.
Version of ExoPlayer being used
2.9.2
Device(s) and version(s) of Android being used
FireTV (any generation)
FireOS 5.2.6.8
A full bug report captured from the device
Sent via email.
The text was updated successfully, but these errors were encountered: