-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FfmpegAudioRenderer fails to correctly handle channel layout changes in MPEG-TS streams #2552
Comments
It's also worth noting that if the audio is allowed to passthrough to the TV attached to the shield for decoding (and downmixing to 2 channel), the sample plays back fine. |
FYI - I'll be travelling, and away from any Android TV dev stuff starting Friday for 2 weeks - any responses needed will be slow, apologies. Let me know if you need anything and I'll do my best! |
Hey guys, anything you need from me to confirm this issue etc? Thanks! |
Sorry for the delay on this. I think I know what the issue might be. I'll run some tests and update this issue. |
Awesome, thanks @AquilesCanta :) |
A fix will be available in the next push. |
This allows propagating format changes to the track output. Issue:#2552 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=152672983
Fixed in |
And, validated it works nicely! Thanks :) |
Possibly related to / a regression of #2111
Issue description
When FfmpegAudioRenderer is used for decoding an AC3 audio track, and that track's channel layout changes abruptly (as is common on MPEG-TS streams during commercial breaks etc), audio and video begins to stutter.
It's possible this isn't AC3 specific, but I don't have any other samples available to verify.
Reproduction steps
Add provided sample into the demo player media.exolist.json, example:
Build the demo app, with the ffmpeg extension enabled.
Play the sample, wait for approx 1:01 and observe stuttering.
Link to test content
https://www.dropbox.com/s/0uvzypw9ckusnqr/ac3-channel-layout-change.ts?dl=0
Version of ExoPlayer being used
Device(s) and version(s) of Android being used
Reproduces on:
A full bug report captured from the device
https://www.dropbox.com/s/py4bpiqds4pbb3g/bugreport-NYC-2017-03-12-22-55-21.zip?dl=0
The text was updated successfully, but these errors were encountered: