Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mp4 video with audio stream type mp3 is played without sound #2066

Closed
vishnuganta22 opened this issue Nov 15, 2016 · 12 comments
Closed

mp4 video with audio stream type mp3 is played without sound #2066

vishnuganta22 opened this issue Nov 15, 2016 · 12 comments
Labels
enhancement

Comments

@vishnuganta22
Copy link

vishnuganta22 commented Nov 15, 2016 •
edited
Loading

No description provided.

@vishnuganta22
Copy link
Author

Video:
Dimensions: 1920*1080
Codec:H.264
Framerate: 24 frames per second

Audio:
Codec: MPEG-1 Layer 3(MP3)
Channels:Stereo
Sample rate: 44100Hz

@vishnuganta22
Copy link
Author

version : exoplayer:r2.0.4

@vishnuganta22
Copy link
Author

Device: Nexus 10
Android version: 5.1.1

@vishnuganta22
Copy link
Author

vishnuganta22 commented Nov 15, 2016 •
edited
Loading

Sent the video file to email(dev.exoplayer@gmail.com)

@andrewlewis
Copy link
Collaborator

The audio track has a .mp3 box in the stsd which we don't currently handle. The code is specified for Quicktime and it looks there is also an alternative way to signal it using an ObjectTypeIndication.

@vishnuganta22
Copy link
Author

@andrewlewis can we expect any estimated time for beta-version of exo-player with the above enhancement.We are waiting for it.

@andrewlewis
Copy link
Collaborator

@vishnuganta22 I don't have a concrete ETA for this yet, but the (unreviewed) patch is very simple:

  1. Add TYPE__mp3 = Util.getIntegerCodeForString(".mp3"); in Atom.java.
  2. Add a check for || childAtomType == Atom.TYPE__mp3 in AtomParsers.java.
  3. Set the MIME type in parseAudioSampleEntry: else if (atomType == Atom.TYPE__mp3) { mimeType = MimeTypes.AUDIO_MPEG; }.

@vishnuganta22
Copy link
Author

@andrewlewis thanks for your comment.
after changing the code as you mentioned it is working.

@vishnuganta22
Copy link
Author

vishnuganta22 commented Nov 16, 2016 •
edited
Loading

@andrewlewis i can't able to able to push my changes to this repo.
getting access denied

@vishnuganta22
Copy link
Author

Want to create a PR with my changes

@andrewlewis
Copy link
Collaborator

Thanks for the pull request, but we have already submitted this change internally. The feature should be available next time we push to dev-v2.

ojw28 pushed a commit that referenced this issue Nov 18, 2016
@andrewlewis @ojw28
Add support for reading .mp3 boxes in stsd.
64d22ae 
This is used by Quicktime for MP3 tracks.

Issue: #2066

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=139343992
ojw28 pushed a commit that referenced this issue Nov 18, 2016
@andrewlewis @ojw28
Add support for reading .mp3 boxes in stsd.
0effffb 
This is used by Quicktime for MP3 tracks.

Issue: #2066

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=139209989
@ojw28
Copy link
Contributor

ojw28 commented Nov 18, 2016

This should be fixed in dev-v1 and dev-v2.

@ojw28 ojw28 closed this as completed Nov 18, 2016
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewlewis @ojw28 @vishnuganta22