-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for container format sniffing in HLS #2025
Comments
The reason behind this bug is that the vtt segments don't have a .vtt/.webvtt extension. This means that the stream does not get past preparing state for V1. I couldn't find any constrains over the extension of the segment URIs in the spec so this is an actual bug. For the time being, if you can rename the webvtt segments so that they end with .vtt, that will fix the issue for you. |
Thanks for quick response. |
According to the spec, subtitle renditions must be Webvtt media segments. Issue:#2025 Issue:#2355 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=145289266
Issue:#2025 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=200212344
Issue:#2025 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=211977802
Support has been added to 2.9.0. |
For the HLS stream below, ExoPlayer fails to display subtitles:
http://drod05p-vh.akamaihd.net/i/all/clear/download/bd/58049ebc6187a40d7cea30bd/Hammerslag--1-10-_5d30d8de7cab45628de5820ac0d965cc_,309,502,956,2059,2880,.mp4.csmil/master.m3u8?cc1=name=Dansk~default=yes~forced=no~lang=da~uri=https://www.dr.dk/mu/subtitles/playlist/urn:dr:mu:manifest:58049ebc6187a40d7cea30bd?segmentsizeinms=60000%26subtitleType=HardOfHearing
When played in Safari on Mac OS, subtitles are displayed correctly for this stream.
ExoPlayer seems to recognize the available subtiles and lists them in the subtitle-selection-dialog displayed when clicking the "Text" button. However, selecting the subtiles "da, id:Dansk" and clicking "OK" does not activate the subtitles. No errors are printed in logcat.
ExoPlayer version: DemoPlayer 2.0.4
Devices tested: HTC One m9 & HTC 10
Reproducible every time.
The text was updated successfully, but these errors were encountered: