-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eac3 audio in video #10791
Comments
This sounds like a problem with the way you're building or depending on the ffmpeg extension, rather than anything specific about eac3. Have you made sure to follow the full instructions for building the extension? https://github.com/google/ExoPlayer/blob/release-v2/extensions/ffmpeg/README.md It's unlikely we can offer much detailed support with the specifics of your build setup I'm afraid. |
I did, i have placed Exoplayer locally and have imported every library I needed like this
After that i followed the guides, I have used ndk 21 , and now i have a FFMPEG folder inside Exoplayer/extesions/ffmpeg/src/main/jni... And after that And I still have no sound , FFmpeg.isAvaible continues to give false but i'm 100% that I didnt skip any step from this guide |
If I try to do this step -> `
FAILURE: Build failed with an exception.
ninja: error: 'C:/Users/Fabio/ExoPlayer/extensions/ffmpeg/src/main/jni/ffmpeg/android-libs/arm64-v8a/libswresample.a', needed by 'C:/Users/Fabio/ExoPlayer/extensions/ffmpeg/buildout/intermediates/cxx/RelWithDebInfo/6p3re6p1/obj/
BUILD FAILED in 12s |
Found the problem It's impossible to do this correctly:
because we get the following error :
There isn't any pkg-config inside NDK , how this should even work ? |
So I found the solution and I will post here to help anothers with the same problem. Inside build_ffmpeg.sh we have a command called "make" (used in linux) but windows doesn't know it , so you have to install chocolatey on power shell , and then "choco install make", after that you need to close all terminals and open again and from that you follow those exoplayer guidelines and everything should work fine. To test if everything is ok you must receive true from calling "Ffmpeg.isAvailable" inside your project. Btw, exoplayer team please update the documentation with this step. |
Glad you got it resolved!
The instructions currently make clear they're not tested on Windows. I will take a look at adding I'm going to close this since the question has been solved. |
These flags ensure that any errors cause the script to exit (instead of just carrying on) (`-e`) and that any unrecognised substitution variables cause an error instead of silently resolving to an empty string (`-u`). Issues like Issue: #10791 should be more quickly resolved with `set -e` because the script will clearly fail with an error like `make: command not found` which would give the user a clear pointer towards the cause of the problem. #minor-release PiperOrigin-RevId: 490001419
These flags ensure that any errors cause the script to exit (instead of just carrying on) (`-e`) and that any unrecognised substitution variables cause an error instead of silently resolving to an empty string (`-u`). Issues like Issue: google/ExoPlayer#10791 should be more quickly resolved with `set -e` because the script will clearly fail with an error like `make: command not found` which would give the user a clear pointer towards the cause of the problem. #minor-release PiperOrigin-RevId: 490001419
I have a video that has "eac3 audio codec" , the video works perfectly but with no audio.
I've tried to use ffmpeg , i did built .aar successfully and added to the libs of my project, but when I call "Ffmpeg.isAvailable" , I always get "false" as response, so I assume is not working.
My .aar has 13kb of size and I added eac3 to the decoders.
What should I do now ? I really need to use exoplayer I didn't want to switch.
Thanks.
The text was updated successfully, but these errors were encountered: