Fix inconsistency with spec in H.265 SPS nal units parsing

Issue: #9719 #minor-release PiperOrigin-RevId: 412424558
google · Nov 26, 2021 · dbec03b · dbec03b
1 parent 0e65925
commit dbec03b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
@@ -5,6 +5,9 @@
 *   Core library:
     *   Support preferred video role flags in track selection
         ((#9402)[https://github.com/google/ExoPlayer/issues/9402]).
+*   Extractors:
+    *   Fix inconsistency with spec in H.265 SPS nal units parsing
+        ((#9719)[https://github.com/google/ExoPlayer/issues/9719]).
 *   DRM:
     *   Remove `playbackLooper` from `DrmSessionManager.(pre)acquireSession`.
         When a `DrmSessionManager` is used by an app in a custom `MediaSource`,

diff --git a/library/extractor/src/main/java/com/google/android/exoplayer2/util/NalUnitUtil.java b/library/extractor/src/main/java/com/google/android/exoplayer2/util/NalUnitUtil.java
@@ -779,7 +779,7 @@ private static void skipShortTermReferencePictureSets(ParsableNalUnitBitArray bi
         bitArray.skipBit(); // delta_rps_sign
         bitArray.readUnsignedExpGolombCodedInt(); // abs_delta_rps_minus1
         for (int j = 0; j <= previousNumDeltaPocs; j++) {
-          if (bitArray.readBit()) { // used_by_curr_pic_flag[j]
+          if (!bitArray.readBit()) { // used_by_curr_pic_flag[j]
             bitArray.skipBit(); // use_delta_flag[j]
           }
         }