-
Notifications
You must be signed in to change notification settings - Fork 6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make dependency on AndroidX appcompat optional for dialog builder.
The dependency is only used to create a dialog in TrackSelectionDialogBuilder that is compatible with newer styling options. This dependendy adds over 500Kb to the apk (even if unused) and we shoudn't force this on an app. Instead make the dependency optional by automatically falling back to the platform version if the AndroidX one doesn't exist. Issue: #7357 PiperOrigin-RevId: 322143005
- Loading branch information
Showing
4 changed files
with
80 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Proguard rules specific to the UI module. | ||
|
||
# Constructor method accessed via reflection in TrackSelectionDialogBuilder | ||
-dontnote androidx.appcompat.app.AlertDialog.Builder | ||
-keepclassmembers class androidx.appcompat.app.AlertDialog$Builder { | ||
<init>(android.content.Context); | ||
public android.content.Context getContext(); | ||
public androidx.appcompat.app.AlertDialog$Builder setTitle(java.lang.CharSequence); | ||
public androidx.appcompat.app.AlertDialog$Builder setView(android.view.View); | ||
public androidx.appcompat.app.AlertDialog$Builder setPositiveButton(int, android.content.DialogInterface$OnClickListener); | ||
public androidx.appcompat.app.AlertDialog$Builder setNegativeButton(int, android.content.DialogInterface$OnClickListener); | ||
public androidx.appcompat.app.AlertDialog create(); | ||
} | ||
|
||
# Don't warn about checkerframework and Kotlin annotations | ||
-dontwarn org.checkerframework.** | ||
-dontwarn kotlin.annotations.jvm.** | ||
-dontwarn javax.annotation.** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../proguard-rules.txt |