Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement to_latest: true #466

Closed
mkmik opened this issue Sep 21, 2023 · 2 comments · Fixed by #498
Closed

Implement to_latest: true #466

mkmik opened this issue Sep 21, 2023 · 2 comments · Fixed by #498
Labels
enhancement New feature or request

Comments

@mkmik
Copy link

mkmik commented Sep 21, 2023

TL;DR

When using no_traffic: true once, it's hard to set the traffic

Docs for --no-traffic state:

After a deployment with this flag the LATEST revision will not receive traffic on future deployments

This can be worked around by adding another step that does:

run: gcloud run services update-traffic ${{service}} --region ${{region}} --to-latest

The current situation is suboptimal because:

  1. the user needs to duplicate the service and region parameters (or factor them out in variables) that are also used by the main deploy step
  2. it's hard to discover because the deploy-cloudrun page doesn't mention this issue of using --no-traffic

Detailed design

Expose a to_latest value that if true will cause the action to call update-traffic with the --to-latest flag, similarly how presence of the revision_traffic and tag_traffic values already do

Additional information

No response

@mkmik mkmik added the enhancement New feature or request label Sep 21, 2023
@wshobson
Copy link

Could we please get a status update on the implementation progress of this detailed design?

@sethvargo
Copy link
Member

revision_traffic: 'LATEST=100'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants