Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain compatibility with Python 3.13 #375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Maintain compatibility with Python 3.13 #375

wants to merge 1 commit into from

Conversation

daskol
Copy link
Contributor

@daskol daskol commented Jan 10, 2025 •
edited
Loading

Resolve #371.

@daskol daskol marked this pull request as ready for review January 10, 2025 18:15
@daskol
Copy link
Contributor Author

daskol commented Jan 14, 2025

Wheels dm-tree for Python 3.13 are missing. Building dm-tree from tarball with default gcc fails because of missing typedefs of uint8_t and uint64_t in absl/strings/internal/str_format/extension.h of vendored abseil library. Upstream issue is google-deepmind/tree#119.

This was referenced Jan 15, 2025
Closed
Merged
@medaminezghal
Copy link

@daskol try to remove the "python_version < "3.13"" in the "https://github.com/google-deepmind/chex/blob/master/requirements/requirements-test.txt" file and rebuild the package.

@daskol
Improve support with Python 3.13
ee17c47 
- Resolve breacking change in `dataclasses`
- Update matrix of supported Pythons
- Update testing dependencies
- Minimal version with Python 3.13 support follows.
  - cloudpickle@3.1.0
  - dm-tree@0.1.9
@daskol
Copy link
Contributor Author

daskol commented Feb 9, 2025 •
edited
Loading

@jakevdp Take a look at this PR, please. It became stale until I added support for Python 3.13 in google-deepmind/tree#123. Then Sergei Lebedev uploaded cp313 wheels in PyPI on the last days of January.

This branch is squashed and rebased on top of the latest changes in master.

@medaminezghal
Copy link

@stompchicken Could you approve this change and update the package to be compatible with python 3.13?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed in the test process in Python 3.13
2 participants
@daskol @medaminezghal