Added cooling energy (E3) support #121
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 77.87% 77.87%
=======================================
Files 8 8
Lines 357 357
=======================================
Hits 278 278
Misses 79 79 ☔ View full report in Codecov by Sentry. |
| SensorEntityDescription( | ||
| key="63", # 0x003F | ||
| name="Cooling Energy (E3)", | ||
| icon="mdi:weather-windy", |
There was a problem hiding this comment.
Do you think this is the best icon to use here?
https://pictogrammers.com/library/mdi/
There was a problem hiding this comment.
I have searched the provided url before but this was the most fitting icon I could find, but I'm open to suggestions offcourse.
There was a problem hiding this comment.
Maybe I found to more fitting icons, what do you think?
https://pictogrammers.com/library/mdi/icon/snowflake/
https://pictogrammers.com/library/mdi/icon/thermometer-minus/
There was a problem hiding this comment.
All 3 of them are not perfectly describing this energy sensor, since this is your PR, I let you pick one and then we go for it!
There was a problem hiding this comment.
I decided to go with snowflake because I think that it most closely resembles the goal of the cooling energy that is metered, just like the radiator icon for the heating meter.
8cec108 to
c0b709b
Compare
|
We can ignore failing |
c0b709b to
a49f171
Compare
|
Thanks @noahlvb ! |
My house has floor heating and also floor cooling and thus my meter which is a Kamstrup 403 has two meters, the usual E1 meter and also E3 for cooling energy. I have found the command for E3 and added it. I have been tested this code on my own meter and the readings are correct (the same as on the display).
I have disabled the sensor by default to preserve battery and because not all users will have the E3 meter.
I found it hard to find the codes/commands, so in case it might be useful to someone:
documentation
Github Gist
The document is for a different meter but the Kamstrup protocol is mostly the same across devices and most codes lie up.