Skip to content

Commit

Permalink
build: downgraded cypress to 13.5.1 as the 13.6.x version causes issu…
Browse files Browse the repository at this point in the history
…es in CI
  • Loading branch information
grisha87 committed Dec 18, 2023
1 parent 16047a6 commit 588fe38
Show file tree
Hide file tree
Showing 5 changed files with 157 additions and 15 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@ jobs:
name: Build and unit-test on supported platforms and NodeJS versions
strategy:
matrix:
node-version: [18.x, 20.x]
# Make sure you're addressing it to the minor version, as sometimes macos was picking 20.9 while others 20.10
# and that caused issues with rollup
node-version: [18.19.x, 20.10.x]
os: [ubuntu-latest, windows-latest, macos-latest]

runs-on: ${{ matrix.os }}
timeout-minutes: 5
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,13 @@ jobs:
name: Build and unit-test on supported platforms and NodeJS versions
strategy:
matrix:
node-version: [18.x, 20.x]
# Make sure you're addressing it to the minor version, as sometimes macos was picking 20.9 while others 20.10
# and that caused issues with rollup
node-version: [18.19.x, 20.10.x]
os: [ubuntu-latest, windows-latest, macos-latest]

runs-on: ${{ matrix.os }}
timeout-minutes: 5
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
Expand Down
31 changes: 26 additions & 5 deletions examples/web/image.html
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ <h3>Logs</h3>
li.appendChild(document.createTextNode(msg));
logs_el.appendChild(li);
}

function setResponse(result) {
if (urlObject) {
URL.revokeObjectURL(urlObject);
Expand All @@ -99,11 +100,31 @@ <h3>Logs</h3>
}

const logger = {
log: (msg) => appendLog(`[${new Date().toISOString()}] ${msg}`),
warn: (msg) => appendLog(`[${new Date().toISOString()}] [warn] ${msg}`),
debug: (msg) => appendLog(`[${new Date().toISOString()}] [debug] ${msg}`),
error: (msg) => appendLog(`[${new Date().toISOString()}] [error] ${msg}`),
info: (msg) => appendLog(`[${new Date().toISOString()}] [info] ${msg}`),
log: (msg) => {
const fullMsg = `[${new Date().toISOString()}] ${msg}`;
console.log(fullMsg);
appendLog(fullMsg);
},
warn: (msg) => {
const fullMsg = `[${new Date().toISOString()}] [warn] ${msg}`;
console.warn(fullMsg);
appendLog(fullMsg);
},
debug: (msg) => {
const fullMsg = `[${new Date().toISOString()}] [debug] ${msg}`;
console.debug(fullMsg);
appendLog(fullMsg);
},
error: (msg) => {
const fullMsg = `[${new Date().toISOString()}] [error] ${msg}`;
console.error(fullMsg);
appendLog(fullMsg);
},
info: (msg) => {
const fullMsg = `[${new Date().toISOString()}] [info] ${msg}`;
console.log(fullMsg);
appendLog(fullMsg);
},
};

async function run() {
Expand Down
124 changes: 120 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"jsdelivr": "dist/golem-js.min.js",
"unpkg": "dist/golem-js.min.js",
"scripts": {
"build": "rollup -c --no-watch",
"build": "rollup -c",
"dev": "rollup -c -w",
"docs": "typedoc src/ --plugin typedoc-plugin-merge-modules --plugin typedoc-theme-hierarchy",
"docs:md": "typedoc src/ --plugin typedoc-plugin-markdown --plugin .docs/typedoc-frontmatter-theme.cjs --hideBreadcrumbs true && node .docs/summary-generator.cjs",
Expand Down Expand Up @@ -80,7 +80,8 @@
"@typescript-eslint/eslint-plugin": "^6.14.0",
"@typescript-eslint/parser": "^6.14.0",
"buffer": "^6.0.3",
"cypress": "13.6.1",
"cypress": "^13.5.1",
"cypress-log-to-output": "^1.1.2",
"eslint": "^8.56.0",
"eslint-config-prettier": "^9.1.0",
"express": "^4.18.2",
Expand Down

0 comments on commit 588fe38

Please sign in to comment.