-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest x/tools #930
Conversation
Did you measure slowdown because of not including fixes in golangci/tools? |
I've rebased and checked for performance regressions. Branch: INFO File cache stats: 137 entries of total size 2.5MiB
INFO Memory: 429 samples, avg is 2344.3MB, max is 4132.5MB
INFO Execution took 54.096474958s
Command exited with non-zero status 1
Command being timed: "/src/golangci-lint/dist/golangci-lint_linux_amd64/golangci-lint run --disable unused --timeout 1h --verbose"
User time (seconds): 528.70
System time (seconds): 10.16
Percent of CPU this job got: 992%
Elapsed (wall clock) time (h:mm:ss or m:ss): 0:54.27
Average shared text size (kbytes): 0
Average unshared data size (kbytes): 0
Average stack size (kbytes): 0
Average total size (kbytes): 0
Maximum resident set size (kbytes): 4183268
Average resident set size (kbytes): 0
Major (requiring I/O) page faults: 708
Minor (reclaiming a frame) page faults: 1104224
Voluntary context switches: 834066
Involuntary context switches: 155082
Swaps: 0
File system inputs: 271448
File system outputs: 130624
Socket messages sent: 0
Socket messages received: 0
Signals delivered: 0
Page size (bytes): 4096
Exit status: 1 v1.23.3 INFO File cache stats: 140 entries of total size 2.5MiB
INFO Memory: 424 samples, avg is 2369.1MB, max is 3731.2MB
INFO Execution took 53.467114645s
Command exited with non-zero status 1
Command being timed: "/src/golangci-lint/bin/golangci-lint run --disable unused --timeout 1h --verbose"
User time (seconds): 529.55
System time (seconds): 9.77
Percent of CPU this job got: 1003%
Elapsed (wall clock) time (h:mm:ss or m:ss): 0:53.73
Average shared text size (kbytes): 0
Average unshared data size (kbytes): 0
Average stack size (kbytes): 0
Average total size (kbytes): 0
Maximum resident set size (kbytes): 3792600
Average resident set size (kbytes): 0
Major (requiring I/O) page faults: 168
Minor (reclaiming a frame) page faults: 969709
Voluntary context switches: 842769
Involuntary context switches: 146200
Swaps: 0
File system inputs: 40992
File system outputs: 130656
Socket messages sent: 0
Socket messages received: 0
Signals delivered: 0
Page size (bytes): 4096
Exit status: 1 Looks like no major differences except 10% maximum RAM usage increase. I'm going to rebase and merge it if tests will be green. |
I've re-visited open PR's for golang/tools: Seems like it was a lot of (~697) commits since then, so let's try upstream version. |
* tag 'v1.23.7': (140 commits) dev: prepare v1.23.7 autogenerated_exclude: increase scanner max buffer size dev: use go1.14 change increase to increasing in timeout error dev: release v1.23.6 tools: update goreleaser dev: release v1.23.5 Support Go 1.14rc1. Simplify alpine Dockerfile add missing mips option Update to latest x/tools (golangci#930) fix golangci#869 by removing lock file after unlocking (golangci#947) dev: release v1.23.3 autogenerated_exclude: increase scanner buffer (golangci#955) gocritic: update disabled check warning message Add MIPS arch support dev: release v1.23.2 Fix misspelled words. (golangci#952) Add Intuit to README.md (golangci#936) fix golangci.yml reference ...
Updates to latest
x/tools
to fix issues with some vet analyzers (see: #915), installing viago get
, and running with Go 1.14.x (see: #893).