Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid position when missing EOL #5279

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix: invalid position when missing EOL #5279

merged 1 commit into from
Jan 2, 2025

Conversation

ldez
Copy link
Member

@ldez ldez commented Jan 2, 2025

Fixes #5278

@ldez ldez added bug Something isn't working linter: update Update the linter implementation inside golangci-lint labels Jan 2, 2025
@ldez ldez added this to the next milestone Jan 2, 2025
@ldez ldez requested a review from bombsimon January 2, 2025 12:05
bombsimon
bombsimon approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️

@ldez ldez merged commit 15412b3 into golangci:master Jan 2, 2025
15 checks passed
@ldez ldez deleted the fix/end-of-line branch January 2, 2025 12:35
@ldez ldez modified the milestones: next, v1.63 Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Milestone
v1.63
Development

Successfully merging this pull request may close these issues.

Invalid line number panic
2 participants
@ldez @bombsimon