Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove decoder, sloglint, tagalin from 'format' preset #5242

Merged
merged 1 commit into from
Dec 21, 2024
Merged

fix: remove decoder, sloglint, tagalin from 'format' preset #5242

merged 1 commit into from
Dec 21, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Dec 21, 2024

decoder, sloglint, tagalin are not formatters but just linters related to "style".

@ldez ldez added the topic: cleanup Related to code, process, or doc cleanup label Dec 21, 2024
@ldez ldez added this to the next milestone Dec 21, 2024
alexandear
alexandear approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a breaking change. We should probably add the "linter: update" label.

@ldez ldez changed the title dev: remove decoder, sloglint, tagalin from 'format' preset fix: remove decoder, sloglint, tagalin from 'format' preset Dec 21, 2024
@ldez ldez added the linter: update Update the linter implementation inside golangci-lint label Dec 21, 2024
@ldez ldez merged commit e11de60 into golangci:master Dec 21, 2024
15 checks passed
@ldez ldez deleted the fix/wrong-presets branch December 21, 2024 21:19
@ldez ldez modified the milestones: next, v1.63 Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandear alexandear alexandear approved these changes

Assignees
No one assigned
Labels
linter: update Update the linter implementation inside golangci-lint topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
v1.63
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @alexandear