nolintlint: remove empty line in unused directive replacement #4973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for opening your first Pull Request ! |
|
|
|
Hello, can you add a description to your PR? |
|
Hi @ldez, I've added a description to the pull request. |
07ded93 to
f1d1bb5
Compare
uudashr
pushed a commit
to uudashr/golangci-lint
that referenced
this pull request
Sep 18, 2024
…ci#4973) Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
nolintlintlinter in autofix mode, it does not remove the empty line along with the unused linter directive if it starts from a new line. Expected behavior: should remove the empty line.