Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump github.com/daixiang0/gci from 0.9.1 to 0.10.0 #3674

Closed
wants to merge 1 commit into from
Closed

build(deps): bump github.com/daixiang0/gci from 0.9.1 to 0.10.0 #3674

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 12, 2023 •
edited
Loading

Bumps github.com/daixiang0/gci from 0.9.1 to 0.10.0.

Release notes

Sourced from github.com/daixiang0/gci's releases.

v0.10.0

New Feature

What's Changed

New Contributors

Full Changelog: daixiang0/gci@v0.9.1...v0.10.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Relates to an upstream dependency go Pull requests that update Go code labels Mar 12, 2023
@ldez ldez self-requested a review March 12, 2023 11:53
@dependabot
build(deps): bump github.com/daixiang0/gci from 0.9.1 to 0.10.0
8c97f6e 
Bumps [github.com/daixiang0/gci](https://github.com/daixiang0/gci) from 0.9.1 to 0.10.0.
- [Release notes](https://github.com/daixiang0/gci/releases)
- [Commits](daixiang0/gci@v0.9.1...v0.10.0)

---
updated-dependencies:
- dependency-name: github.com/daixiang0/gci
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/daixiang0/gci-0.10.0 branch from 67cd03f to 8c97f6e Compare March 12, 2023 12:15
@ldez ldez added the blocked Need's direct action from maintainer label Mar 12, 2023
@ldez
Copy link
Member

ldez commented Mar 12, 2023 •
edited
Loading

This update has a side effect that creates panic on windows and macOS.

I bet that the problem is related to daixiang0/gci@c19c1aa

ping @daixiang0

@daixiang0
Copy link
Contributor

I will check it.

@daixiang0
Copy link
Contributor

CI failures are caused by

Cannot find relationship with gci, any clue is welcome!

@ldez
Copy link
Member

ldez commented Mar 13, 2023 •
edited
Loading

I have already watched the CI: I'm 100% sure it's related to a side effect of gci.
The failure append on random linter because it's not related to those linters.

And I think that the problem is related to daixiang0/gci@c19c1aa

@daixiang0
Copy link
Contributor

I will add some tests in CI and try to find the root cause.

@daixiang0 daixiang0 mentioned this pull request Mar 13, 2023
Closed
@daixiang0
Copy link
Contributor

daixiang0/gci#151 fix this.

@ldez
Copy link
Member

ldez commented Mar 13, 2023

So I will close this PR and wait for a new release of gci.

@ldez ldez closed this Mar 13, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 13, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@ldez ldez added declined and removed blocked Need's direct action from maintainer labels Mar 13, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/daixiang0/gci-0.10.0 branch March 13, 2023 08:12
@ldez ldez added the linter: update version Update version of linter label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez Awaiting requested review from ldez

Assignees
No one assigned
Labels
declined dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @daixiang0