Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.dev/_content/blog: fix embedded videos in two posts #93

Closed
wants to merge 1 commit into from
Closed

go.dev/_content/blog: fix embedded videos in two posts #93

wants to merge 1 commit into from

Conversation

180909
Copy link
Contributor

@180909 180909 commented Sep 8, 2021 •
edited
Loading

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 8, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 5da61a4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/348249 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@180909 180909 changed the title fix video can't display all: fix video can't display Sep 8, 2021
@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 2: Code-Review+1 Trust+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/348249.
After addressing review feedback, remember to publish your drafts!

@180909 180909 changed the title all: fix video can't display go.dev/_content/blog: fix embedded videos in two posts Sep 14, 2021
@gopherbot
Copy link
Contributor

Message from Jamal Carvalho:

Patch Set 3: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/348249.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jamal Carvalho:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/348249.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/348249.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/348249.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 15, 2021
@180909 @rsc
go.dev/_content/blog: fix embedded videos in two posts
7cc6415 
Fixes golang/go#48235

Change-Id: I204e8f24290c1c4c411b522d6fbed535741fb0c8
GitHub-Last-Rev: 5da61a4
GitHub-Pull-Request: #93
Reviewed-on: https://go-review.googlesource.com/c/website/+/348249
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/348249 has been merged.

@gopherbot gopherbot closed this Sep 15, 2021
MK825 added a commit to MK825/website that referenced this pull request Oct 18, 2022
@MK825
go.dev/_content/blog: fix embedded videos in two posts
da084fb 
Fixes golang/go#48235

Change-Id: I204e8f24290c1c4c411b522d6fbed535741fb0c8
GitHub-Last-Rev: 5da61a437c63493867c34997372ad85c9451531f
GitHub-Pull-Request: golang/website#93
Reviewed-on: https://go-review.googlesource.com/c/website/+/348249
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/website: Some pages cannot display video
2 participants
@180909 @gopherbot