-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format: resolve variables in customFormatter field #2942
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: cec997d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/520015. Important tips:
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/520015. |
@uniquefine Are you still planning to get this PR merged? I would love to see this long-standing issue get closed, as I have some code that would be able to take advantage of the fix. |
Yes, I was waiting for a review. I'll resolve the conflicts and ping the maintainers in slack. |
🚀 |
I encountered the same issue. In my case, I want to add |
@uniquefine What's left to get this merged? I'd still really like to see it get merged in. |
Message from Hyang-Ah Hana Kim: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/520015. |
Fixes #2582 Originally PR #2942. Co-authored-by: Sebastian Leisinger <leisinger@anapaya.net> Change-Id: If4e2802ba4ab02e85830cf71883e0cc9557540f5 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/576296 Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
This PR is being closed because golang.org/cl/520015 has been abandoned. Submitted rebased change https://go-review.git.corp.google.com/c/vscode-go/+/576296 |
Fixes #2582