src/goDebugConfiguration.ts: add support for `string` typed `args` #2670

weikanglim · 2023-02-18T06:12:04Z

This change adds support for user specifying args as a single string-typed launch argument in launch.json.

The argument string is parsed into word arguments with rules consistent with bash. No shell expansion is performed.

gopherbot · 2023-02-18T06:18:19Z

This PR (HEAD: e6ae23b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/469378 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-02-18T06:28:09Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/469378.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-02-19T05:46:16Z

This PR (HEAD: 48639fa) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/469378 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-04-27T03:24:20Z

This PR (HEAD: b7c6cd6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/469378 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-04-27T15:44:26Z

Message from Hyang-Ah Hana Kim:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/469378.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-05-01T03:14:27Z

This PR (HEAD: ff4b222) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/469378 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

weikanglim · 2023-05-01T03:27:36Z

@hyangah My apologies. I had misunderstood where the VSCode parsing of the args was happening. The parseArgs logic is moved to goDebugConfiguration.ts now, which is where it should be. I tested it locally (based on the scenario I described in #2621) and everything works as expected. Please let me know if anything additional is needed.

gopherbot · 2023-05-03T16:19:00Z

Message from Hyang-Ah Hana Kim:

Patch Set 4: Run-TryBot+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/469378.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-05-03T16:25:12Z

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/8e18f31c-1001-49f6-b9df-78af41a5b7c1

Please don’t reply on this GitHub thread. Visit golang.org/cl/469378.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-05-03T16:30:49Z

Message from kokoro:

Patch Set 4: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/8e18f31c-1001-49f6-b9df-78af41a5b7c1

Please don’t reply on this GitHub thread. Visit golang.org/cl/469378.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-05-04T03:38:56Z

This PR (HEAD: 624b832) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/469378 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-05-04T03:44:28Z

This PR (HEAD: c4e4391) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/469378 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-05-04T03:50:05Z

This PR (HEAD: 8cab551) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/469378 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-05-04T04:06:13Z

Message from WeiKang Lim:

Patch Set 7:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/469378.
After addressing review feedback, remember to publish your drafts!

weikanglim · 2023-05-11T02:35:50Z

@hyangah Apologies for the ping, but if anyone from the team has the chance to review this -- my team is eagerly excited for this feature (if it ends up landing)!

hyangah · 2023-05-11T18:22:19Z

@weikanglim My apologies - our CI is broken and I am looking into it. Once it passes the build, I will approve and merge. Sorry for the delay.

gopherbot · 2023-05-11T18:45:27Z

Message from siv Solean:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/469378.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-05-12T20:58:20Z

Message from Hyang-Ah Hana Kim:

Patch Set 8: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/469378.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-05-12T23:48:04Z

This PR (HEAD: 56d13c6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/469378 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-05-13T18:03:47Z

This PR (HEAD: 3d5cd26) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/469378 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-05-13T18:21:44Z

Message from WeiKang Lim:

Patch Set 10:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/469378.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-05-15T14:35:00Z

Message from Hyang-Ah Hana Kim:

Patch Set 10: Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/469378.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-05-15T14:35:01Z

Message from kokoro:

Patch Set 10:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/63cbb9ad-fa10-414a-a084-26f071c89f1d

Please don’t reply on this GitHub thread. Visit golang.org/cl/469378.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-05-15T14:46:41Z

Message from kokoro:

Patch Set 10: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/63cbb9ad-fa10-414a-a084-26f071c89f1d

Please don’t reply on this GitHub thread. Visit golang.org/cl/469378.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-05-15T17:27:10Z

Message from Heschi Kreinick:

Patch Set 10: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/469378.
After addressing review feedback, remember to publish your drafts!

This change adds support for user specifying `args` as a single `string`-typed launch argument in `launch.json`. The argument string is parsed into word arguments with rules consistent with `bash`. No shell expansion is performed. Fixes [#2621](#2621) Change-Id: I26d279ac304afa307bf3023ee8835582bb903a05 GitHub-Last-Rev: 3d5cd26 GitHub-Pull-Request: #2670 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/469378 Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Heschi Kreinick <heschi@google.com> TryBot-Result: kokoro <noreply+kokoro@google.com>

gopherbot · 2023-05-15T18:12:15Z

This PR is being closed because golang.org/cl/469378 has been merged.

This is a follow-up change from #2670 to update the schema. This avoids intellisense warning squiggly lines when updating `launch.json` while using a `string` type for `args`. Validated by importing the local `.vsix` extension, and verifying no warnings show up for `string` and `array` args. Fixes #2621 Change-Id: I13248d65a2a13d4cf2b40921e7af4613ec3ce253 GitHub-Last-Rev: f6fefc3 GitHub-Pull-Request: #2777 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/495816 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Suzy Mueller <suzmue@golang.org> TryBot-Bypass: Hyang-Ah Hana Kim <hyangah@gmail.com> Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>

weikanglim added 5 commits February 17, 2023 21:36

Add parseArgsString

d753b14

Add usage in debug adapter

88896b5

Update export interface

9a78994

fix test assertion

ed1fea4

add missing newline

e6ae23b

Add backslash for escaping

48639fa

Add better comments and copyright message

b7c6cd6

weikanglim added 4 commits April 30, 2023 20:00

Revet change to legacy debugger

34e78db

Add parsing of args

83831b8

make error message more concise

8e0a8e7

Merge remote-tracking branch 'upstream/master' into args-string

ff4b222

weikanglim changed the title ~~src/debugAdapter: add support for string typed args~~ src/goDebugConfiguration.ts: add support for string typed args May 1, 2023

address linter problems

624b832

Fix error message return

c4e4391

apply prettier

8cab551

weikanglim added 2 commits May 12, 2023 16:42

Merge remote-tracking branch 'origin/master' into args-string

2358d5f

Update year

56d13c6

Fix copyright notice in util.test.ts

3d5cd26

gopherbot closed this May 15, 2023

weikanglim mentioned this pull request May 17, 2023

package.json: update launch args schema #2777

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src/goDebugConfiguration.ts: add support for `string` typed `args` #2670

src/goDebugConfiguration.ts: add support for `string` typed `args` #2670

weikanglim commented Feb 18, 2023 •

edited

Loading

gopherbot commented Feb 18, 2023

gopherbot commented Feb 18, 2023

gopherbot commented Feb 19, 2023

gopherbot commented Apr 27, 2023

gopherbot commented Apr 27, 2023

gopherbot commented May 1, 2023

weikanglim commented May 1, 2023

gopherbot commented May 3, 2023

gopherbot commented May 3, 2023

gopherbot commented May 3, 2023

gopherbot commented May 4, 2023

gopherbot commented May 4, 2023

gopherbot commented May 4, 2023

gopherbot commented May 4, 2023

weikanglim commented May 11, 2023

hyangah commented May 11, 2023

gopherbot commented May 11, 2023

gopherbot commented May 12, 2023

gopherbot commented May 12, 2023

gopherbot commented May 13, 2023

gopherbot commented May 13, 2023

gopherbot commented May 15, 2023

gopherbot commented May 15, 2023

gopherbot commented May 15, 2023

gopherbot commented May 15, 2023

gopherbot commented May 15, 2023

src/goDebugConfiguration.ts: add support for string typed args #2670

src/goDebugConfiguration.ts: add support for string typed args #2670

Conversation

weikanglim commented Feb 18, 2023 • edited Loading

gopherbot commented Feb 18, 2023

gopherbot commented Feb 18, 2023

gopherbot commented Feb 19, 2023

gopherbot commented Apr 27, 2023

gopherbot commented Apr 27, 2023

gopherbot commented May 1, 2023

weikanglim commented May 1, 2023

gopherbot commented May 3, 2023

gopherbot commented May 3, 2023

gopherbot commented May 3, 2023

gopherbot commented May 4, 2023

gopherbot commented May 4, 2023

gopherbot commented May 4, 2023

gopherbot commented May 4, 2023

weikanglim commented May 11, 2023

hyangah commented May 11, 2023

gopherbot commented May 11, 2023

gopherbot commented May 12, 2023

gopherbot commented May 12, 2023

gopherbot commented May 13, 2023

gopherbot commented May 13, 2023

gopherbot commented May 15, 2023

gopherbot commented May 15, 2023

gopherbot commented May 15, 2023

gopherbot commented May 15, 2023

gopherbot commented May 15, 2023

src/goDebugConfiguration.ts: add support for `string` typed `args` #2670

src/goDebugConfiguration.ts: add support for `string` typed `args` #2670

weikanglim commented Feb 18, 2023 •

edited

Loading