protoc-gen-go/grpc: make grpc identical to v1.3.5 #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even through the grpc package is excluded from our compatibility agreement, the v1.4.0 release accidentally reverted the package to an older revision. Update this code to be identical to the v1.3.5 release (barring non-semantic documentation changes). Fixes #1111
neild
approved these changes
May 4, 2020
This was referenced Mar 16, 2021
Closed
n3xem
reviewed
Feb 28, 2023
| methName := generator.CamelCase(method.GetName()) | ||
| statusPkg := string(g.gen.AddImport(statusPkgPath)) | ||
| codePkg := string(g.gen.AddImport(codePkgPath)) | ||
| g.P("return ", nilArg, statusPkg, `.Errorf(`, codePkg, `.Unimplemented, "method `, methName, ` not implemented")`) |
There was a problem hiding this comment.
@dsnet
May I ask why you are using the Errorf method? In my view, it should be the Error method since the error message doesn’t require formatting.
please let me know if you remember the answer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even through the grpc package is excluded from our compatibility agreement,
the v1.4.0 release accidentally reverted the package to an older revision.
Update this code to be identical to the v1.3.5 release (barring non-semantic
documentation changes).
Fixes #1111