-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/oauth2: clarify that ExpiresIn is not automatically populated by the package #747
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 71e6027) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/621195. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621195. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/621195. |
71e6027
to
117a894
Compare
This PR (HEAD: 117a894) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/621195. Important tips:
|
…e package Related golang/go#61417 merges golang#747 (golang#747)
This change may get obsoleted by #748 |
Added a note to the
ExpiresIn
field documentation to clarify that the oauth2 package does not automatically populate theExpiresIn
field, even if the server returns an "expires_in" value. This change helps prevent confusion for developers expecting ExpiresInto be set when interacting with methods like
Config.Exchange`.