publicsuffix: spruce up code gen and speed up PublicSuffix

[jub0bs]

Rely on functions from the slices package where convenient. Drop custom max functions in favor of max builtin. Remove unused non-exported functions.

Reduce the number of bounds checks. Replace calls to strings.LastIndex by calls to strings.LastIndexByte.

goos: darwin
goarch: amd64
pkg: golang.org/x/net/publicsuffix
cpu: Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
│ old │ new │
│ sec/op │ sec/op vs base │
PublicSuffix-8 13.46µ ± 0% 13.23µ ± 0% -1.67% (p=0.000 n=20)

           │    old     │              new               │
           │    B/op    │    B/op     vs base            │

PublicSuffix-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20) ¹
¹ all samples are equal

           │    old     │              new               │
           │ allocs/op  │ allocs/op   vs base            │

PublicSuffix-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=20) ¹
¹ all samples are equal

[gopherbot]

This PR (HEAD: 87567e7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/652236.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from Gopher Robot:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/652236.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Damien Neil:

Patch Set 3: Commit-Queue+1

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/652236.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-28T00:46:01Z","revision":"b4bf6cf9dbd3253cdf70efa4ada1706819e3638b"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/652236.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Damien Neil:

Patch Set 3: Code-Review+2

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/652236.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Damien Neil:

Patch Set 3: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/652236.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/652236.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/652236.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Michael Pratt:

Patch Set 3: Code-Review+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/652236.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR is being closed because golang.org/cl/652236 has been merged.