Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: crypto/tls: add cipher suites TLS_ECDHE_PSK #53602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jclab-joseph
Copy link

@jclab-joseph jclab-joseph commented Jun 29, 2022

Added cipher suites:

  • TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA
  • TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA256
  • TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA
  • TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA384

Related Issue: #6379

@google-cla
Copy link

google-cla bot commented Jun 29, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gopherbot
Copy link
Contributor

This PR (HEAD: 71243d9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/415034 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/415034.
After addressing review feedback, remember to publish your drafts!

@jclab-joseph jclab-joseph changed the title crypto/tls: add cipher suites TLS_ECDHE_PSK wip: crypto/tls: add cipher suites TLS_ECDHE_PSK Jun 29, 2022
@gopherbot
Copy link
Contributor

This PR (HEAD: 3738b9b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/415034 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 89c27c3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/415034 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@jclab-joseph
Copy link
Author

Question: How to make testdata?

@gopherbot
Copy link
Contributor

This PR (HEAD: 24318fd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/415034 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@jclab-joseph
Copy link
Author

jclab-joseph commented Jun 30, 2022

Example:

package tls_test

import (
	"errors"
	"log"
	"testing"
	"time"
)

var defaultPskConfig = tls.PSKConfig{
	GetIdentity: func() string {
		return "abcd"
	},
	GetKey: func(identity string) ([]byte, error) {
		if identity == "abcd" {
			return []byte("123456"), nil
		}
		return nil, errors.New("Invalid identity: " + identity)
	},
}

func TestPeerConnection(t *testing.T) {
	cfg := &tls.Config{
		MaxVersion: tls.VersionTLS12,
		Extra:      defaultPskConfig,
		CipherSuites: []uint16{
			tls.TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA,
			tls.TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA,
			tls.TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA384,
			tls.TLS_ECDHE_PSK_WITH_CHACHA20_POLY1305_SHA256,
		},
		InsecureSkipVerify: true,
		Certificates:       []tls.Certificate{tls.Certificate{}},
	}
	clientConfig := &tls.Config{
		MaxVersion: tls.VersionTLS12,
		Extra:      defaultPskConfig,
		CipherSuites: []uint16{
			tls.TLS_ECDHE_PSK_WITH_AES_128_CBC_SHA,
			tls.TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA,
			tls.TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA384,
			tls.TLS_ECDHE_PSK_WITH_CHACHA20_POLY1305_SHA256,
		},
		InsecureSkipVerify: true,
	}

	listener, err := tls.Listen("tcp", ":2000", cfg)
	if err != nil {
		log.Fatal(err)
	}

	go func() {
		for {
			conn, err := listener.Accept()
			if err != nil {
				log.Printf(err.Error())
				continue
			}
			go func() {
				buffer := make([]byte, 128)
				len, err := conn.Read(buffer)
				if err != nil {
					log.Printf(err.Error())
				}

				log.Printf("READ %d Bytes: %s", len, string(buffer))
			}()
		}
	}()

	time.Sleep(time.Second / 2)

	func() {
		conn, err := tls.Dial("tcp", "127.0.0.1:2000", clientConfig)
		if err != nil {
			log.Fatal(err)
		}
		conn.Write([]byte("HELLO WORLD"))
		conn.Close()
	}()
}

Test Workflow : https://github.com/jc-lab/go-tls-psk/actions

@gopherbot
Copy link
Contributor

This PR (HEAD: e296a6b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/415034 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants