-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go/internal/modfetch: prevent duplicate hashes in go.sum #53291
Conversation
To write go.sum, each module and then each hash is looped through. The hashes are kept in a slice and there is no check to ensure that hashes were not added or already exist in the file. This uniques the hashes of each module before writting to prevent duplicates. Fixes: #28456
This PR (HEAD: a76c0f8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/411154 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/411154. |
Message from Daniel Martí: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/411154. |
This PR (HEAD: 0ed02e9) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/411154 to see it. Tip: You can toggle comments from me using the |
Message from Bryan Mills: Patch Set 3: Run-TryBot+1 Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/411154. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/411154. |
Message from Bryan Mills: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/411154. |
Message from Gopher Robot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/411154. |
Message from Josh Powers: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/411154. |
Message from Bryan Mills: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/411154. |
Message from Josh Powers: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/411154. |
Message from Bryan Mills: Patch Set 4: Run-TryBot+1 Auto-Submit+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/411154. |
Message from Bryan Mills: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/411154. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/411154. |
Message from Gopher Robot: Patch Set 4: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/411154. |
To write go.sum, each module and then each hash is looped through. The hashes are kept in a slice and there is no check to ensure that hashes were not added or already exist in the file. Therefore, unique the hashes of each module before writing to prevent duplicates. Fixes: #28456 Change-Id: I1cf7e7cdee3e7530a0ee605cd76d738627be1e0d GitHub-Last-Rev: 0ed02e9 GitHub-Pull-Request: #53291 Reviewed-on: https://go-review.googlesource.com/c/go/+/411154 Auto-Submit: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This PR is being closed because golang.org/cl/411154 has been merged. |
To write go.sum, each module and then each hash is looped through. The
hashes are kept in a slice and there is no check to ensure that hashes
were not added or already exist in the file. Therefore, unique the
hashes of each module before writing to prevent duplicates.
Fixes: #28456