Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update oudated comment #45976

Closed
wants to merge 3 commits into from
Closed

Update oudated comment #45976

wants to merge 3 commits into from

Conversation

MakDon
Copy link
Contributor

@MakDon MakDon commented May 5, 2021 •
edited
Loading

Update comment cause gc/select.go has been moved to walk/select.go and gc/reflect.go has been moved to reflectdata/reflect.go

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 5, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 2525cd0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/317191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Keith Randall:

Patch Set 1: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/317191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/317191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/317191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Pratt:

Patch Set 1: Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/317191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Pratt:

Patch Set 1: Code-Review+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/317191.
After addressing review feedback, remember to publish your drafts!

@MakDon MakDon changed the title runtime/select: update comment for gc/select runtime: update comment for gc/select May 9, 2021
@gopherbot
Copy link
Contributor

Message from makdon:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/317191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from makdon:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/317191.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 622db2f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/317191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@MakDon MakDon changed the title runtime: update comment for gc/select Update oudated comment May 17, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 6d6a447) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/317191 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from makdon:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/317191.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jul 8, 2021
@MakDon @randall77
Update oudated comment
ce76298 
Update comment cause gc/select.go has been moved to walk/select.go and gc/reflect.go has been moved to reflectdata/reflect.go

Change-Id: I6894527e1e9dbca50ace92a51bf942f9495ce88c
GitHub-Last-Rev: 6d6a447
GitHub-Pull-Request: #45976
Reviewed-on: https://go-review.googlesource.com/c/go/+/317191
Reviewed-by: Keith Randall <khr@golang.org>
Trust: Michael Pratt <mpratt@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/317191 has been merged.

@gopherbot gopherbot closed this Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MakDon @gopherbot