Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/modget: improve GOINSECURE docs #38572

Closed
wants to merge 2 commits into from
Closed

cmd/go/internal/modget: improve GOINSECURE docs #38572

wants to merge 2 commits into from

Conversation

witchard
Copy link
Contributor

Recommend use of GOINSECURE over -insecure flang and clarify that GOINSECURE
environment variable does not also imply GONOSUMDB.

Updates #37519 by adding documentation as discussed.

@witchard
cmd/go/internal/modget: Improve GOINSECURE docs.
16f0896 
Recommend use of GOINSECURE over -insecure flang and clarify that GOINSECURE
environment variable does not also imply GONOSUMDB.
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Apr 21, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 16f0896) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/229223 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Jay Conrod:

Patch Set 1:

(2 comments)

Thanks for working on this! A couple small comments, but this looks good.

Please don’t reply on this GitHub thread. Visit golang.org/cl/229223.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Matloob:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/229223.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jay Conrod:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/229223.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from witchard:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/229223.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from witchard:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/229223.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 8d86991) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/229223 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 2: Run-TryBot+1 Code-Review+1

This seems broadly positive to me. Since it looks like Jay and Michael have already reviewed in more depth, I'll leave the details up to them.

Please don’t reply on this GitHub thread. Visit golang.org/cl/229223.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1cc7272d

Please don’t reply on this GitHub thread. Visit golang.org/cl/229223.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/229223.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 23, 2020
@witchard
cmd/go/internal/modget: improve GOINSECURE docs
708ac9a 
Recommend use of GOINSECURE over -insecure flang and clarify that GOINSECURE
environment variable does not also imply GONOSUMDB.

Updates #37519 by adding documentation as discussed.

Change-Id: Ia8ab6b3ed1aa559343b72e4ca76c372ee6bf1941
GitHub-Last-Rev: 8d86991
GitHub-Pull-Request: #38572
Reviewed-on: https://go-review.googlesource.com/c/go/+/229223
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link
Contributor

Message from Jay Conrod:

Patch Set 2: Code-Review+2

Looks good. Thanks for adding this!

Please don’t reply on this GitHub thread. Visit golang.org/cl/229223.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/229223 has been merged.

@gopherbot gopherbot closed this Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@witchard @gopherbot @googlebot