Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go list fails with submodules which have test-only dependencies [1.19 backport] #60697

Closed
gopherbot opened this issue Jun 8, 2023 · 3 comments
Closed

cmd/go: go list fails with submodules which have test-only dependencies [1.19 backport] #60697

gopherbot opened this issue Jun 8, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go release-blocker
Milestone
Go1.19.11

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #60667 to be considered for backport to the next 1.19 minor release.

@gopherbot, please backport to Go 1.19 and 1.20. This is a regression introduced in a previous patch release.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 8, 2023
@gopherbot gopherbot mentioned this issue Jun 8, 2023
Closed
@gopherbot gopherbot added this to the Go1.19.11 milestone Jun 8, 2023
@dmitshur dmitshur added the GoCommand cmd/go label Jun 8, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/502017 mentions this issue: [release-branch.go1.19] cmd/go: omit checksums for go.mod files needed for go version lines more often in pre-1.21 modules

@bcmills
Copy link
Contributor

bcmills commented Jun 12, 2023

Approving as a fix for a regression in the previous minor release.

@bcmills bcmills added CherryPickApproved Used during the release process for point releases release-blocker labels Jun 12, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 12, 2023
@gopherbot
Copy link
Contributor Author

Closed by merging 1d85bce to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Jun 13, 2023
@prattmic
[release-branch.go1.19] cmd/go: omit checksums for go.mod files neede…
1d85bce 
…d for go version lines more often in pre-1.21 modules

This updates the logic from CL 489075 to avoid trying to save extra
sums if they aren't already expected to be present
and cfg.BuildMod != "mod" (as in the case of "go list -m -u all" with
a go.mod file that specifies go < 1.21).

Fixes #60697.
Updates #60667.
Updates #56222.

Change-Id: Ied6ed3e80a62f9cd9a328b43a415a42d14481056
Reviewed-on: https://go-review.googlesource.com/c/go/+/502017
Reviewed-by: Michael Matloob <matloob@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Bypass: Bryan Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go release-blocker
Projects
None yet
Milestone
Go1.19.11
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot