net: inconsistent error values #4856

dvyukov · 2013-02-20T15:39:23Z

func (fd *netFD) Read(p []byte) (n int, err error) {
    ...
    if err := fd.incref(false); err != nil {
        return 0, err
    }
    ...
    if err != nil && err != io.EOF {
        err = &OpError{"read", fd.net, fd.raddr, err}
    }

Can return either errClosing or OpError depending on timings between Read and Close.

There are similar cases in other reads and writes.

And there are other inconsistencies, e.g. 
func Listen(net, laddr string) (Listener, error)
returns either UnknownNetworkError or &OpError{"listen", net, laddr,
otherError} or &OpError{"dial", net + " " + addr, nil,
UnknownNetworkError(net)}

I don't have a full list, just something I've noticed.

rsc · 2013-03-12T20:18:48Z

Comment 2:

[The time for maybe has passed.]

Labels changed: removed go1.1maybe.

adg · 2013-03-22T21:08:06Z

Comment 3:

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

rsc · 2013-07-30T16:44:03Z

Comment 4:

Labels changed: added go1.2maybe.

rsc · 2013-07-30T22:41:15Z

Comment 5:

Labels changed: added feature.

mikioh · 2013-08-13T22:04:57Z

Comment 6:

This issue was updated by revision 45cb2e1.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12763044

mikioh · 2013-08-29T01:27:41Z

Comment 7:

This issue was updated by revision e4bb139.

R=golang-dev, bradfitz, dave
CC=golang-dev
https://golang.org/cl/12916046

mikioh · 2013-08-29T09:15:48Z

Comment 8:

I think I've done what I planned to do for Go 1.2.
In Go 1.3, we'll do the rest except controversial read/write stuff.
Then, wish someone makes it clear how to return io.EOF, errClosing on read/write ops.

Labels changed: added go1.3maybe, removed go1.2maybe.

rsc · 2013-11-27T20:29:16Z

Comment 9:

Labels changed: removed feature.

rsc · 2013-12-04T01:28:16Z

Comment 10:

Labels changed: added release-none, removed go1.3maybe.

rsc · 2013-12-04T01:48:38Z

Comment 11:

Labels changed: added repo-main.

mikioh · 2014-04-07T21:14:34Z

Comment 12:

This issue was updated by revision 3f5288c.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/84660046

mikioh · 2014-04-07T21:15:04Z

Comment 13:

This issue was updated by revision a2a3514.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/84800044

gopherbot · 2014-04-09T01:58:50Z

Comment 14:

CL https://golang.org/cl/84750043 references this issue.

gopherbot · 2014-04-09T01:59:50Z

Comment 15:

CL https://golang.org/cl/84750043 references this issue.

gopherbot · 2014-04-10T00:49:31Z

Comment 16:

CL https://golang.org/cl/85630044 mentions this issue.

mikioh · 2014-05-02T02:47:25Z

Comment 17:

Labels changed: added release-go1.4, removed priority-later, release-none.

rsc · 2014-09-16T15:01:18Z

Comment 18:

Issue #7721 has been merged into this issue.

rsc · 2014-09-16T15:01:41Z

Comment 19:

See issue #7721 for test case to consider.

rsc · 2014-09-16T15:02:00Z

Comment 20:

Issue #7708 has been merged into this issue.

rsc · 2014-09-16T15:02:11Z

Comment 21:

And see issue #7708 for another.

rsc · 2014-09-16T15:13:11Z

Comment 22:

Seems too late for 1.4.

Labels changed: added release-go1.5, removed release-go1.4.

…n windows Preventing returning io.EOF on non-connection oriented sockets is already applied to Unix variants. This CL applies it to Windows. Update #4856. Change-Id: I82071d40f617e2962d0540b9d1d6a10ea4cdb2ec Reviewed-on: https://go-review.googlesource.com/2203 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>

In followup changes, we'll move OpError around from the netFD layer to the Conn layer for fixing golang#4856. Before doing that, this change makes netFD of Plan 9 match netFD for POSIX platforms to avoid conflict. Change-Id: Iea7632716d48722a1758e52effefec964a3a9442 Reviewed-on: https://go-review.googlesource.com/8990 Reviewed-by: David du Colombier <0intro@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

This change makes TestDialError, TestListenError work without any external dependency, enables them by default, and removes unnecessary -run_error_test flag for fixing #4856. Also fixes inconsistent error values on Dial, Listen partially as a first stab. Updates #4856. Change-Id: Ie10c151ae06759085f352c7db2ca45107a81914f Reviewed-on: https://go-review.googlesource.com/8903 Reviewed-by: Ian Lance Taylor <iant@golang.org>

This change fixes inconsistent error values on Read, ReadFrom{,UDP,IP,Unix} and ReadMsg{UDP,IP,Unix}. Updates golang#4856. Change-Id: I7de5663094e09be2d78cdb18ce6f1e7ec260888d Reviewed-on: https://go-review.googlesource.com/8992 Reviewed-by: Ian Lance Taylor <iant@golang.org>

This change fixes inconsistent error values on Write, WriteTo{,UDP,IP,Unix} and WriteMsg{UDP,IP,Unix}. Updates #4856. Change-Id: I4208ab6a0650455ad7d70a80a2d6169351d6055f Reviewed-on: https://go-review.googlesource.com/8993 Reviewed-by: Ian Lance Taylor <iant@golang.org>

This change fixes inconsistent error values on Close, CloseRead and CloseWrite. Updates #4856. Change-Id: I3c4d46ccd7d6e1a2f52d8e75b512f62c533a368d Reviewed-on: https://go-review.googlesource.com/8994 Reviewed-by: Ian Lance Taylor <iant@golang.org>

This change fixes inconsistent error values on Accept{,TCP,Unix}. Updates #4856. Change-Id: Ie3bb534c19a724cacb3ea3f3656e46c810b2123f Reviewed-on: https://go-review.googlesource.com/8996 Reviewed-by: Ian Lance Taylor <iant@golang.org>

This change fixes inconsistent error values on File{Conn,Listener,PacketConn} and File method of Conn, Listener. Updates #4856. Change-Id: I3197b9277bef0e034427e3a44fa77523acaa2520 Reviewed-on: https://go-review.googlesource.com/9101 Reviewed-by: Ian Lance Taylor <iant@golang.org>

This change fixes inconsistent error values on Set{Deadline,ReadDeadline,WriteDeadline,ReadBuffer,WriteBuffer} for Conn, Listener and PacketConn, and Set{KeepAlive,KeepAlivePeriod,Linger,NoDelay} for TCPConn. Updates #4856. Change-Id: I34ca5e98f6de72863f85b2527478b20d8d5394dd Reviewed-on: https://go-review.googlesource.com/9109 Reviewed-by: Ian Lance Taylor <iant@golang.org>

This change fixes inconsistent error values on Interfaces, InterfaceAddrs, InterfaceBy{Index,Name}, and Addrs and MulticastAddrs methods of Interface. Updates #4856. Change-Id: I09e65522a22f45c641792d774ebf7a0081b874ad Reviewed-on: https://go-review.googlesource.com/9140 Reviewed-by: Ian Lance Taylor <iant@golang.org>

This change fixes inconsistent error values on Lookup{Addr,CNAME,Host,IP.MX,NS,Port,SRV,TXT}. Updates #4856. Change-Id: I059bc8ffb96ee74dff8a8c4e8e6ae3e4a462a7ef Reviewed-on: https://go-review.googlesource.com/9108 Reviewed-by: Ian Lance Taylor <iant@golang.org>

gopherbot · 2015-04-25T20:18:52Z

CL https://golang.org/cl/9231 mentions this issue.

gopherbot · 2015-04-25T20:19:00Z

CL https://golang.org/cl/9236 mentions this issue.

Not only by network, transport-layer intermediaries but by virtualization stuff in a node, it is hard to identify the root cause of weird faults without information of packet flows after disaster happened. This change adds Source field to OpError to be able to represent a 5-tuple of internet transport protocols for helping dealing with complicated systems. Also clarifies the usage of Source and Addr fields. Updates #4856. Change-Id: I96a523fe391ed14406bfb21604c461d4aac2fa19 Reviewed-on: https://go-review.googlesource.com/9231 Reviewed-by: Ian Lance Taylor <iant@golang.org>

Updates #4856. Change-Id: Ia04e24fb1fe57e244d7b1cd417f7f419ad610acd Reviewed-on: https://go-review.googlesource.com/9776 Reviewed-by: Aram Hăvărneanu <aram@mgk.ro>

dvyukov added accepted labels Sep 16, 2014

This was referenced Dec 8, 2014

net: error on connectionless-mode write doesn't contain address information #7708

Closed

net: error on closed connection write doesn't contain address information #7721

Closed

bradfitz modified the milestone: Go1.5 Dec 16, 2014

bradfitz removed the release-go1.5 label Dec 16, 2014

mikioh mentioned this issue Mar 17, 2015

net: errClosing not exported #4373

Closed

rsc removed accepted labels Apr 14, 2015

mikioh closed this as completed in 055ecb7 May 5, 2015

mikioh pushed a commit that referenced this issue May 6, 2015

net: fix inconsistent error values on Read for solaris

9d0a2e4

Updates #4856. Change-Id: Ia04e24fb1fe57e244d7b1cd417f7f419ad610acd Reviewed-on: https://go-review.googlesource.com/9776 Reviewed-by: Aram Hăvărneanu <aram@mgk.ro>

jeffallen mentioned this issue Jul 17, 2015

net: DNSError.IsTimeout almost never set #8748

Closed

golang locked and limited conversation to collaborators Jun 24, 2016

gopherbot added the FrozenDueToAge label Jun 24, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: inconsistent error values #4856

net: inconsistent error values #4856

dvyukov commented Feb 20, 2013

rsc commented Mar 12, 2013

adg commented Mar 22, 2013

rsc commented Jul 30, 2013

rsc commented Jul 30, 2013

mikioh commented Aug 13, 2013

mikioh commented Aug 29, 2013

mikioh commented Aug 29, 2013

rsc commented Nov 27, 2013

rsc commented Dec 4, 2013

rsc commented Dec 4, 2013

mikioh commented Apr 7, 2014

mikioh commented Apr 7, 2014

gopherbot commented Apr 9, 2014

gopherbot commented Apr 9, 2014

gopherbot commented Apr 10, 2014

mikioh commented May 2, 2014

rsc commented Sep 16, 2014

rsc commented Sep 16, 2014

rsc commented Sep 16, 2014

rsc commented Sep 16, 2014

rsc commented Sep 16, 2014

gopherbot commented Apr 25, 2015

gopherbot commented Apr 25, 2015

net: inconsistent error values #4856

net: inconsistent error values #4856

Comments

dvyukov commented Feb 20, 2013

rsc commented Mar 12, 2013

adg commented Mar 22, 2013

rsc commented Jul 30, 2013

rsc commented Jul 30, 2013

mikioh commented Aug 13, 2013

mikioh commented Aug 29, 2013

mikioh commented Aug 29, 2013

rsc commented Nov 27, 2013

rsc commented Dec 4, 2013

rsc commented Dec 4, 2013

mikioh commented Apr 7, 2014

mikioh commented Apr 7, 2014

gopherbot commented Apr 9, 2014

gopherbot commented Apr 9, 2014

gopherbot commented Apr 10, 2014

mikioh commented May 2, 2014

rsc commented Sep 16, 2014

rsc commented Sep 16, 2014

rsc commented Sep 16, 2014

rsc commented Sep 16, 2014

rsc commented Sep 16, 2014

gopherbot commented Apr 25, 2015

gopherbot commented Apr 25, 2015