Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: loops forever on sched_yield sometimes(timer related) [1.14 backport] #38051

Closed
gopherbot opened this issue Mar 24, 2020 · 3 comments
Closed

runtime: loops forever on sched_yield sometimes(timer related) [1.14 backport] #38051

gopherbot opened this issue Mar 24, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.2

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #38023 to be considered for backport to the next 1.14 minor release.

@gopherbot Please open backport issue for 1.14.

This problem can cause Go programs to hang in some circumstances, with no workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 24, 2020
@gopherbot gopherbot mentioned this issue Mar 24, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.2 milestone Mar 24, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/225277 mentions this issue: [release-branch.go1.14] runtime: don't call wakeNetPoller during timerModifying

@ianlancetaylor
Copy link
Member

This problem can cause Go programs to hang in some circumstances, with no workaround, as discussed #38023 and #38072. Cherry pick approved.

@ianlancetaylor ianlancetaylor added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 25, 2020
@gopherbot
Copy link
Contributor Author

Closed by merging ca153f4 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Mar 25, 2020
@ianlancetaylor
[release-branch.go1.14] runtime: don't call wakeNetPoller during time…
ca153f4 
…rModifying

Reduce the length of time that other timer functions can see timerModifying.
In particular avoid system calls.

For #38023
Fixes #38051

Change-Id: I1b61229c668e6085d9ee6dca9488a90055386c36
Reviewed-on: https://go-review.googlesource.com/c/go/+/224902
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
(cherry picked from commit 355f53f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/225277
@knz knz mentioned this issue Apr 30, 2020
Closed
This was referenced Jun 16, 2020
Closed
Closed
@golang golang locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.2
Development

No branches or pull requests
2 participants
@ianlancetaylor @gopherbot