Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: drop support for macOS 10.10 at some point #26513

Closed
bradfitz opened this issue Jul 20, 2018 · 4 comments
Closed

all: drop support for macOS 10.10 at some point #26513

bradfitz opened this issue Jul 20, 2018 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Milestone
Unplanned

Comments

@bradfitz
Copy link
Contributor

Eventually we'll drop support for macOS 10.10.

This bug collects TODO items for when we do so.

/cc @aclements
@bradfitz
Copy link
Contributor Author

https://go-review.googlesource.com/c/go/+/125304/3/misc/cgo/test/issue24161_darwin_test.go for #26475

@bradfitz bradfitz added this to the Unplanned milestone Jul 20, 2018
@bradfitz bradfitz added OS-Darwin NeedsFix The path to resolution is known, but the work has not been done. labels Jul 20, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/125304 mentions this issue: misc/cgo/test: disable some Darwin tests in cgo mode

gopherbot pushed a commit that referenced this issue Jul 23, 2018
@aclements
misc/cgo/test: disable some Darwin tests in cgo mode
30d7e64 
For unknown reasons, linking against CoreFoundation on macOS 10.10
sometimes causes mmap to ignore the hint address, which makes the Go
allocator incompatible with TSAN. Currently, the effect of this is to
run the allocator out of arena hints on the very first allocation,
causing a "too many address space collisions for -race mode" panic.

This CL skips the cgo tests that link against CoreFoundation in race
mode.

Updates #26475.
Updates #26513.

Change-Id: I52ec638c99acf5d4966e68ff0054f7679680dac6
Reviewed-on: https://go-review.googlesource.com/125304
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
@aclements aclements mentioned this issue Jul 23, 2018
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/189578 mentions this issue: doc/install-source.html: add new GOOS and GOARCHes

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/214057 mentions this issue: misc/cgo/test: re-enable darwin cgo tests in race mode

gopherbot pushed a commit that referenced this issue Jan 10, 2020
@tklauser
misc/cgo/test: re-enable darwin cgo tests in race mode
5d076d5 
Go 1.14 will drop support for macOS 10.10, see #23011

This reverts CL 125304

Updates #26475
Updates #26513

Change-Id: Ia13eef30f22d67103f7ae45424124fbb116e1261
Reviewed-on: https://go-review.googlesource.com/c/go/+/214057
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot