Skip to content

Commit

Permalink
cmd/gc: fix special-casing of the printed names of map internal struc…
Browse files Browse the repository at this point in the history
…tures.

Shaves 1% off of binary size.

update #6853

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/35940047
  • Loading branch information
randall77 committed Dec 3, 2013
1 parent 0368a7c commit f238049
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 9 deletions.
18 changes: 11 additions & 7 deletions src/cmd/gc/fmt.c
Original file line number Diff line number Diff line change
Expand Up @@ -702,13 +702,17 @@ typefmt(Fmt *fp, Type *t)
case TSTRUCT:
// Format the bucket struct for map[x]y as map.bucket[x]y.
// This avoids a recursive print that generates very long names.
if(t->hmap != T) {
t = t->hmap;
return fmtprint(fp, "map.bucket[%T]%T", t->down, t->type);
}
if(t->hiter != T) {
t = t->hiter;
return fmtprint(fp, "map.iter[%T]%T", t->down, t->type);
if(t->map != T) {
if(t->map->bucket == t) {
return fmtprint(fp, "map.bucket[%T]%T", t->map->down, t->map->type);
}
if(t->map->hmap == t) {
return fmtprint(fp, "map.hdr[%T]%T", t->map->down, t->map->type);
}
if(t->map->hiter == t) {
return fmtprint(fp, "map.iter[%T]%T", t->map->down, t->map->type);
}
yyerror("unknown internal map type");
}

if(t->funarg) {
Expand Down
1 change: 1 addition & 0 deletions src/cmd/gc/go.h
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ struct Type
Type* bucket; // internal type representing a hash bucket
Type* hmap; // internal type representing a Hmap (map header object)
Type* hiter; // internal type representing hash iterator state
Type* map; // link from the above 3 internal types back to the map type.

int32 maplineno; // first use of TFORW as map key
int32 embedlineno; // first use of TFORW as embedded type
Expand Down
5 changes: 3 additions & 2 deletions src/cmd/gc/reflect.c
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ mapbucket(Type *t)
bucket->width = offset;
bucket->local = t->local;
t->bucket = bucket;
bucket->map = t;
return bucket;
}

Expand Down Expand Up @@ -229,7 +230,7 @@ hmap(Type *t)
h->width = offset;
h->local = t->local;
t->hmap = h;
h->hmap = t;
h->map = t;
return h;
}

Expand Down Expand Up @@ -308,7 +309,7 @@ hiter(Type *t)
if(off != 11 * widthptr)
yyerror("hash_iter size not correct %d %d", off, 11 * widthptr);
t->hiter = i;
i->hiter = t;
i->map = t;
return i;
}

Expand Down

0 comments on commit f238049

Please sign in to comment.