This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
hack/validate-vendor.bash: fix build dep & script without TRAVIS_BRANCH #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
reviewed
Apr 13, 2017
hack/validate-vendor.bash
Outdated
| go build | ||
| ./dep ensure | ||
| go install ./cmd/dep | ||
| dep ensure |
There was a problem hiding this comment.
Depending on how PATH is setup, this isn't guaranteed to use the binary we just built. Can we fix the build command and continue using ./dep?
carolynvs
reviewed
Apr 13, 2017
hack/validate-vendor.bash
Outdated
|
|
||
| IFS=$'\n' | ||
| files=( $(git diff "$TRAVIS_BRANCH...$VALIDATE_HEAD" --diff-filter=ACMR --name-only -- 'manifest.json' 'lock.json' 'vendor/' || true) ) | ||
| files=( $(validate_diff --diff-filter=ACMR --name-only -- 'manifest.json' 'lock.json' 'vendor/' || true) ) |
There was a problem hiding this comment.
Since #342 was just merged, this should be updated to manifest.json -> Gopkg.toml and lock.json -> Gopkg.lock.
carolynvs
suggested changes
Apr 13, 2017
b3f1bdd to
33cddec
Compare
|
updated, thanks! |
carolynvs
approved these changes
Apr 13, 2017
|
omg 😍 I am not that cool you will soon see, but <3 |
|
😛 Whatevs, you cannot stop my fangirl squee power. |
sdboyer
reviewed
Apr 14, 2017
hack/validate-vendor.bash
Outdated
| unset IFS | ||
|
|
||
| if [ ${#files[@]} -gt 0 ]; then | ||
| # We run ensure to and see if we have a diff afterwards | ||
| go build | ||
| go install ./cmd/dep |
There was a problem hiding this comment.
err wait i'm confused, won't this still install to GOPATH/bin, rather than the current dir? shouldn't it be go build ./cmd/dep?
|
You are correct good catch I changed the other back and not this one...
Will update
…On Apr 13, 2017 20:13, "sam boyer" ***@***.***> wrote:
***@***.**** commented on this pull request.
confoozled
------------------------------
In hack/validate-vendor.bash
<#369 (comment)>:
> unset IFS
if [ ${#files[@]} -gt 0 ]; then
# We run ensure to and see if we have a diff afterwards
- go build
+ go install ./cmd/dep
err wait i'm confused, won't this still install to GOPATH/bin, rather
than the current dir? shouldn't it be go build ./cmd/dep?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#369 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABYNbO5VDEVfBoPRJCjwcQs92ROHBlr2ks5rvroXgaJpZM4M5GuO>
.
|
Signed-off-by: Jess Frazelle <acidburn@google.com>
|
OK I think we're good now, mergey merge time |
ibrasho
pushed a commit
to ibrasho-forks/dep
that referenced
this pull request
May 10, 2017
hack/validate-vendor.bash: fix build dep & script without TRAVIS_BRANCH
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
TRAVIS_BRANCHso the script works the same locally as in Travis. Also fixes "build dep" to run ensure since the command code was moved tocmd/dep.