Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The highlight function's options should be optional #9249

Closed
jmooring opened this issue Dec 6, 2021 · 1 comment · Fixed by #9251
Closed

The highlight function's options should be optional #9249

jmooring opened this issue Dec 6, 2021 · 1 comment · Fixed by #9251
Assignees
@jmooring
Labels
Enhancement Outdated
Milestone
v0.90

Comments

@jmooring
Copy link
Member

jmooring commented Dec 6, 2021

Reference: gohugoio/hugoDocs#63

Currently you have to this:

{{ highlight "<div>foo</div> "html" "" }}

It would be better if you could do this:

{{ highlight "<div>foo</div> "html" }}
@jmooring jmooring self-assigned this Dec 6, 2021
jmooring added a commit to jmooring/hugo that referenced this issue Dec 7, 2021
@jmooring
tpl/transform: Optional options for highlight func
79a2189 
Closes gohugoio#9249
Fixes gohugoio/hugoDocs#63
@jmooring jmooring mentioned this issue Dec 7, 2021
Merged
@bep bep added Enhancement and removed Proposal labels Dec 7, 2021
@bep bep added this to the v0.90 milestone Dec 7, 2021
@bep bep closed this as completed in #9251 Dec 7, 2021
bep pushed a commit that referenced this issue Dec 7, 2021
@jmooring @bep
tpl/transform: Optional options for highlight func
5538507 
Closes #9249
Fixes gohugoio/hugoDocs#63
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmooring jmooring

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.90
Development

Successfully merging a pull request may close this issue.

tpl/transform: Optional options for highlight func jmooring/hugo
2 participants
@jmooring @bep