Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom variables support for menu items #7951

Closed
chrede88 opened this issue Nov 12, 2020 · 2 comments
Closed

Custom variables support for menu items #7951

chrede88 opened this issue Nov 12, 2020 · 2 comments
Labels
Enhancement Outdated
Milestone
v0.79

Comments

@chrede88
Copy link

I would like to see support added for custom variables in menu items. The current supported variables are quite limited and makes it hard to give theme users more customization options.

Adding custom variables could be placed under params, which is consistent with standard Hugo.

[menu]

[[menu.item]]
    identifier = "id"
    name = "name"
    url  = "home/"
    weight = 1
    pre = "<p>pre html</p>"
    post = "<p>post html</p>"

    [menu.item.params]
         customVar = "custom"

I can see that others also previously have raised this: #5953
@bep bep added Enhancement and removed Proposal labels Nov 12, 2020
@bep bep added this to the v0.79 milestone Nov 12, 2020
@bep
Copy link
Member

bep commented Nov 12, 2020

I agree.

@davidejones davidejones mentioned this issue Nov 20, 2020
Merged
@bep bep closed this as completed in 8f5c9a7 Nov 22, 2020
satotake added a commit to satotake/hugo that referenced this issue Nov 24, 2020
@satotake
prototype composite render mode
5a565d2 
docs: Regenerate docshelper

Revert "docs: Regenerate docshelper"

This reverts commit caf16c2.

Closes gohugoio#7972

watcher: Add file deleted by accident

See gohugoio#7972

resources: Preserve url set in frontmatter without sanitizing

related gohugoio#6007 (already closed)

Add menu params

Fixes gohugoio#7951

docs: Regen docshelper

build(deps): bump github.com/getkin/kin-openapi from 0.30.0 to 0.31.0

Bumps [github.com/getkin/kin-openapi](https://github.com/getkin/kin-openapi) from 0.30.0 to 0.31.0.
- [Release notes](https://github.com/getkin/kin-openapi/releases)
- [Commits](getkin/kin-openapi@v0.30.0...v0.31.0)

Signed-off-by: dependabot[bot] <support@github.com>
@fmotrifork fmotrifork mentioned this issue Nov 27, 2020
Merged
@bot-actions bot-actions bot mentioned this issue Nov 30, 2020
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.79
Development

No branches or pull requests
2 participants
@bep @chrede88