Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies in package.json submodules not resolved correctly #7924

Closed
bep opened this issue Nov 3, 2020 · 2 comments · Fixed by #7931
Closed

Dependencies in package.json submodules not resolved correctly #7924

bep opened this issue Nov 3, 2020 · 2 comments · Fixed by #7931
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.78.1

Comments

@bep
Copy link
Member

bep commented Nov 3, 2020

Unless you do a npm install in the modle dir, which is not what you want to do ...
@bep bep added the Bug label Nov 3, 2020
@bep bep added this to the v0.78.1 milestone Nov 3, 2020
@bep bep self-assigned this Nov 3, 2020
@bep
Copy link
Member Author

bep commented Nov 4, 2020

OK, not sure why I did not test this, I kind of expected this to just work. Oh, well. I have a workaround that I'm going to finish and get out there.

Also see evanw/esbuild#502

@bep bep mentioned this issue Nov 4, 2020
Merged
bep added a commit to bep/hugo that referenced this issue Nov 4, 2020
@bep
js: Misc fixes
d50379c 
* Fix resolve of package.json deps in submodules
* Fix directory logic for writing assets/jsconfig.json

Fixes gohugoio#7924
Fixes gohugoio#7923
bep added a commit to bep/hugo that referenced this issue Nov 4, 2020
@bep
js: Misc fixes
8317ff4 
* Fix resolve of package.json deps in submodules
* Fix directory logic for writing assets/jsconfig.json

Fixes gohugoio#7924
Fixes gohugoio#7923
@bep bep closed this as completed in bf2837a Nov 5, 2020
@bot-actions bot-actions bot mentioned this issue Nov 8, 2020
Merged
@fmotrifork fmotrifork mentioned this issue Nov 9, 2020
Merged
@fmotrifork fmotrifork mentioned this issue Nov 27, 2020
Merged
@bot-actions bot-actions bot mentioned this issue Nov 30, 2020
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.78.1
Development

Successfully merging a pull request may close this issue.

js: Misc fixes bep/hugo
1 participant
@bep