Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change images.QR(opts) to images.QR(text, opts) #13230

Closed
bep opened this issue Jan 8, 2025 · 2 comments · Fixed by #13234
Closed

Change images.QR(opts) to images.QR(text, opts) #13230

bep opened this issue Jan 8, 2025 · 2 comments · Fixed by #13234
Assignees
@jmooring
Labels
Enhancement Outdated
Milestone
v0.141.0

Comments

@bep
Copy link
Member

bep commented Jan 8, 2025

I do understand that I argued differently days ago, but I'm doing some test work in that package and this is in line with other funcs:

images.Text "Hugo Rocks!" $textOpts )

And it makes sense to separate the "options" so they can be reused/stored in config etc.
@bep bep self-assigned this Jan 8, 2025
@bep bep added the Enhancement label Jan 8, 2025
@bep bep added this to the v0.141.0 milestone Jan 8, 2025
@jmooring
Copy link
Member

jmooring commented Jan 8, 2025

I'd be happy to take this one if you'd like.

@bep bep assigned jmooring and unassigned bep Jan 8, 2025
@bep bep changed the title Chane images.QR(opts) to images.QR(text, opts) Chagne images.QR(opts) to images.QR(text, opts) Jan 8, 2025
@jmooring jmooring changed the title Chagne images.QR(opts) to images.QR(text, opts) Change images.QR(opts) to images.QR(text, opts) Jan 8, 2025
jmooring added a commit to jmooring/hugo that referenced this issue Jan 8, 2025
@jmooring
tpl/images: Change signature of images.QR to images.QR TEXT OPTIONS
f85d161 
Closes gohugoio#13230
@jmooring jmooring mentioned this issue Jan 8, 2025
Merged
@bep bep closed this as completed in b13d0a6 Jan 8, 2025
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmooring jmooring

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.141.0
Development

Successfully merging a pull request may close this issue.

tpl/images: Change signature of images.QR to images.QR TEXT OPTIONS jmooring/hugo
2 participants
@jmooring @bep