-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix go.mod add go.work #1426
base: development
Are you sure you want to change the base?
Conversation
The path were relative to the root of the project. This caused an error when the repository was named something else than "gofr".
You can use the following command to sync all go.mod and go.sum files: $ go work sync
Please note the so the CI about "sub modules" should be removed Let's talk about it here. |
I think the next step should be done:
Everything works without them now there is a go.work file |
@Umang01-hash could you take back this one As I told you I'm facing personal issue. It's just a matter of test. I would like this to be merged before the following ones: Code is ready. |
Sure @ccoVeille i will take it up after these PR's are merged. |
I'm no longer sure about the next step (at least the second one) There is an interesting discussion here go-testfixtures/testfixtures#257 (comment) That may affect the way the CI changes I was asking to remove might have to stay. |
The relative path in go.mod used in file datasource modules
This caused an error when the repository was named something else than "gofr".
Please note, I'm not even sure there is a logic to use relative path now the dev is over.
Also add missing go.work files
I'm not even sure how the project could be managed without this.
I'm sure there are some part of the CI that could be deleted now the go.work file is present