Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Between version v2.23.0 and v2.24.0 the behavior of Mount changed with regard to how the child's ErrorHandler is used. Before v2.24.0 if the child's error handler was not set, then it used the parent's error handler. From v2.24.0 to v2.39.0 (most recent as of this PR) the behavior is to use the child's error handler (which, even when it isn't explicitly set, is set to the DefaultErrorHandler by
New()
).This change fixes that issue and provides a way for others to fix similar issues as they arise by checking if the value was explicitly configured.
Type of change
Please delete options that are not relevant.
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/